-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not running all requests in the Postman collection #731
Conversation
Codecov Report
@@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 48.37% 48.15% -0.22%
==========================================
Files 68 68
Lines 2245 2255 +10
Branches 426 435 +9
==========================================
Hits 1086 1086
+ Misses 1011 1010 -1
- Partials 148 159 +11
Continue to review full report at Codecov.
|
Example of Postman collection v2.0{
"info": {
"_postman_id": "0653fc29-a517-4f78-820a-66b207c7cd62",
"name": "Monika Monitor Collection",
"schema": "https://schema.getpostman.com/json/collection/v2.0.0/collection.json"
},
"item": [
{
"name": "[GitHub API] Hyperjump",
"protocolProfileBehavior": {
"disableBodyPruning": true
},
"request": {
"method": "GET",
"header": [],
"body": {
"mode": "raw",
"raw": "{\n \"any\": \"any\"\n}\n",
"options": {
"raw": {
"language": "json"
}
}
},
"url": "https://api.github.com/users/hyperjumptech"
},
"response": []
},
{
"name": "[GitHub API] Hyperjump Repos",
"request": {
"method": "GET",
"header": [],
"url": "https://api.github.com/users/hyperjumptech/repos"
},
"response": []
}
]
} Example of Postman collection v2.1{
"info": {
"_postman_id": "0653fc29-a517-4f78-820a-66b207c7cd62",
"name": "Monika Monitor Collection",
"schema": "https://schema.getpostman.com/json/collection/v2.1.0/collection.json"
},
"item": [
{
"name": "[GitHub API] Hyperjump",
"request": {
"method": "GET",
"header": [],
"url": {
"raw": "https://api.github.com/users/hyperjumptech",
"protocol": "https",
"host": [
"api",
"github",
"com"
],
"path": [
"users",
"hyperjumptech"
]
}
},
"response": []
},
{
"name": "[GitHub API] Hyperjump Repos",
"request": {
"method": "GET",
"header": [],
"url": {
"raw": "https://api.github.com/users/hyperjumptech/repos",
"protocol": "https",
"host": [
"api",
"github",
"com"
],
"path": [
"users",
"hyperjumptech",
"repos"
]
}
},
"response": []
}
]
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add the test to make sure the parsed postman config contain the expected number of probes? I think right now the test only checks the first probe.
I've rewritten the entire Postman tests, both integration and unit test 😈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👻 👽 👾
Monika Pull Request (PR)
v2.0