Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not running all requests in the Postman collection #731

Merged
merged 7 commits into from
Jun 24, 2022

Conversation

kevin-hyperjump
Copy link
Contributor

Monika Pull Request (PR)

  1. Fixes Not running all requests in the Postman collection #730
  2. Adds support for Postman collection v2.0

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #731 (f16b115) into main (3c70de7) will decrease coverage by 0.21%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   48.37%   48.15%   -0.22%     
==========================================
  Files          68       68              
  Lines        2245     2255      +10     
  Branches      426      435       +9     
==========================================
  Hits         1086     1086              
+ Misses       1011     1010       -1     
- Partials      148      159      +11     
Impacted Files Coverage Δ
src/components/config/parse-postman.ts 55.55% <54.54%> (-21.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c70de7...f16b115. Read the comment docs.

@kevin-hyperjump
Copy link
Contributor Author

Example of Postman collection v2.0

{
  "info": {
    "_postman_id": "0653fc29-a517-4f78-820a-66b207c7cd62",
    "name": "Monika Monitor Collection",
    "schema": "https://schema.getpostman.com/json/collection/v2.0.0/collection.json"
  },
  "item": [
    {
      "name": "[GitHub API] Hyperjump",
      "protocolProfileBehavior": {
        "disableBodyPruning": true
      },
      "request": {
        "method": "GET",
        "header": [],
        "body": {
          "mode": "raw",
          "raw": "{\n    \"any\": \"any\"\n}\n",
          "options": {
            "raw": {
              "language": "json"
            }
          }
        },
        "url": "https://api.github.com/users/hyperjumptech"
      },
      "response": []
    },
    {
      "name": "[GitHub API] Hyperjump Repos",
      "request": {
        "method": "GET",
        "header": [],
        "url": "https://api.github.com/users/hyperjumptech/repos"
      },
      "response": []
    }
  ]
}

Example of Postman collection v2.1

{
  "info": {
    "_postman_id": "0653fc29-a517-4f78-820a-66b207c7cd62",
    "name": "Monika Monitor Collection",
    "schema": "https://schema.getpostman.com/json/collection/v2.1.0/collection.json"
  },
  "item": [
    {
      "name": "[GitHub API] Hyperjump",
      "request": {
        "method": "GET",
        "header": [],
        "url": {
          "raw": "https://api.github.com/users/hyperjumptech",
          "protocol": "https",
          "host": [
            "api",
            "github",
            "com"
          ],
          "path": [
            "users",
            "hyperjumptech"
          ]
        }
      },
      "response": []
    },
    {
      "name": "[GitHub API] Hyperjump Repos",
      "request": {
        "method": "GET",
        "header": [],
        "url": {
          "raw": "https://api.github.com/users/hyperjumptech/repos",
          "protocol": "https",
          "host": [
            "api",
            "github",
            "com"
          ],
          "path": [
            "users",
            "hyperjumptech",
            "repos"
          ]
        }
      },
      "response": []
    }
  ]
}

Copy link
Member

@nicnocquee nicnocquee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the test to make sure the parsed postman config contain the expected number of probes? I think right now the test only checks the first probe.

@kevin-hyperjump
Copy link
Contributor Author

Can you also add the test to make sure the parsed postman config contain the expected number of probes? I think right now the test only checks the first probe.

I've rewritten the entire Postman tests, both integration and unit test 😈

Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻 👽 👾

@kevin-hyperjump kevin-hyperjump merged commit 1792fc1 into hyperjumptech:main Jun 24, 2022
@kevin-hyperjump kevin-hyperjump deleted the 730 branch June 24, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not running all requests in the Postman collection
4 participants