Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent send backup notification when Monika starts #934

Merged

Conversation

haricnugraha
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Fix send recovery notification when Monika starts. This will resolves Service back up notification when Monika starts #933.

How did you implement / how did you fix it

  1. Add conditional statement to prevent send notification when the first event is up for non Symon mode

How to test

  1. Run Monika with multiple probes

Screenshots

Before

Screenshot from 2022-10-27 15-45-58

After

Screenshot from 2022-10-27 15-47-37

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #934 (3c89cc2) into main (908f32f) will increase coverage by 0.12%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   45.72%   45.85%   +0.12%     
==========================================
  Files          83       83              
  Lines        2821     2824       +3     
  Branches      559      561       +2     
==========================================
+ Hits         1290     1295       +5     
+ Misses       1334     1332       -2     
  Partials      197      197              
Impacted Files Coverage Δ
src/components/probe/index.ts 13.79% <33.33%> (+2.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haricnugraha haricnugraha merged commit 9a4113b into hyperjumptech:main Nov 1, 2022
@haricnugraha haricnugraha deleted the 933/fix-backup-notification branch November 1, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service back up notification when Monika starts
3 participants