Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fix: temporary work around for json ld canonizing issue #1594

Closed

Conversation

sudeshrshetty
Copy link
Contributor

Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #1594 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1594   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         161      161           
  Lines       11138    11144    +6     
=======================================
+ Hits        10188    10194    +6     
  Misses        533      533           
  Partials      417      417           
Impacted Files Coverage Δ
pkg/doc/signature/proof/jws.go 89.33% <100.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4eafc...186bc18. Read the comment docs.

@sudeshrshetty sudeshrshetty force-pushed the interop branch 3 times, most recently from bce8aaf to dbe28fe Compare April 9, 2020 03:30
- Excluding "credentialStatus.type" from VC which is causing document
canonizing issue (hyperledger-archives#1592)
- closes hyperledger-archives#1593

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
Copy link
Contributor

@kdimak kdimak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for a temporary workaround!
#1592 (comment)

@troyronda
Copy link
Contributor

We should fix as noted here:
#1592 (comment)

@troyronda troyronda closed this Apr 9, 2020
@sudeshrshetty sudeshrshetty deleted the interop branch June 10, 2020 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

interop tests : Aries VC with credential status fails signature verification
3 participants