feat: vcwallet client #2542
feat: vcwallet client #2542
Conversation
- closes hyperledger-archives#2541 - part of hyperledger-archives#2433 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #2542 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 256 257 +1
Lines 19896 19906 +10
=======================================
+ Hits 17734 17744 +10
Misses 1269 1269
Partials 893 893
Continue to review full report at Codecov.
|
| SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package vcwallet |
There was a problem hiding this comment.
why vcwallet?
seems to be implementing universal wallet so I would think uniwallet might be more what you mean?
There was a problem hiding this comment.
All non-core interfaces are not in the spec anymore, like storage : add, remove, get.
Other functions like, export, import, lock, unlock, verifyRaw, signRaw are now optional.
Previously I insisted on calling it as universal wallet since our add function implementation was supposed to support all data models. From discussion here generating/adding/removing data models related to wallet contents will be completely controlled by wallet specific interface functions. And, storage interface functions are moved out of spec since they will be wallet implementation specific just like, VDR, KMS etc.
For example, VC wallet doesn't have to implement verifyRaw, SignRaw from the spec since VC wallet issue/prove/verify functions are already verifying proofs (In PR spec#54 verifyRaw & signRaw functions are made optional).
- closes hyperledger-archives#2541 - part of hyperledger-archives#2433 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
- closes hyperledger-archives#2541 - part of hyperledger-archives#2433 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com