This repository has been archived by the owner on May 13, 2022. It is now read-only.
Reintroducing ecrecover and implementing ed25519 signature verification #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smblucker <smblucker@outlook.com>
|
Happy to have these in. We'll not want to import the secp library that you have there, when this is merged (this week hopefully): #776 we'll be using the btcsuite library for that. I'll hold off reviewing those changes until you're able to integrate with our keys stuff - some things will also have moved around. Makes sense to provide these as snatives, and when we have secp support back in we should also re-enable ECRECOVER In vm.go |
|
This change is very useful. Thanks for introducing new method: |
|
@smblucker or @b00f if you have time/desire to work on this then let me know it's not mergeable at present due both to conflicts and the secp C dependency. |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reintroduce functionality for ecrecover implement ed25519 signature verification as defined here:
ethereum/go-ethereum#16453