Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

update the package version scripts to include the peerDependencies #3955

Merged
merged 2 commits into from
May 9, 2018
Merged

update the package version scripts to include the peerDependencies #3955

merged 2 commits into from
May 9, 2018

Conversation

mbwhite
Copy link
Contributor

@mbwhite mbwhite commented May 2, 2018

Adding peer dependencies to the package check scripts.
Behaviour is exactly the same as for the other dependencies.

@mbwhite mbwhite requested review from jt-nti and sstone1 May 2, 2018 13:32
@mbwhite mbwhite force-pushed the fix-version-fix branch from 5322979 to 534fbd4 Compare May 2, 2018 13:33
@mbwhite mbwhite requested a review from nklincoln May 2, 2018 14:18
sstone1
sstone1 previously requested changes May 8, 2018
View reviewed changes
Copy link
Contributor

@sstone1 sstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbwhite y u no run script to fix the peerDependencies?

@mbwhite
Copy link
Contributor Author

mbwhite commented May 8, 2018 

npm run pkgcheck                                                                                                                                                                                    fix-version-fix 

> composer@0.19.5 pkgcheck /home/matthew/github/composer
> node ./scripts/pkgcheck.js

Status: no problems detected!

@mbwhite mbwhite force-pushed the fix-version-fix branch 4 times, most recently from 27a6a5d to 5b16f66 Compare May 8, 2018 12:53
@jt-nti jt-nti self-assigned this May 9, 2018
mbwhite added 2 commits May 9, 2018 10:09
@mbwhite
update the package version scripts to include the peerDependencies
f3db01d 
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
@mbwhite
update package.json
f7748e8 
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
@mbwhite mbwhite force-pushed the fix-version-fix branch from 5b16f66 to f7748e8 Compare May 9, 2018 09:09
@jt-nti jt-nti dismissed sstone1’s stale review May 9, 2018 09:11

package.json now updated

jt-nti
jt-nti approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@jt-nti jt-nti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jt-nti jt-nti merged commit e866a16 into hyperledger-archives:master May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jt-nti jt-nti jt-nti approved these changes

@sstone1 sstone1 sstone1 left review comments

@nklincoln nklincoln Awaiting requested review from nklincoln

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbwhite @jt-nti @sstone1