This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Fix TSLint Errors in Angular Generator #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…home.component TSLint errors Signed-off-by: Zach Gollwitzer <zach.gollwitzer@gmail.com>
…errors Signed-off-by: Zach Gollwitzer <zach.gollwitzer@gmail.com>
|
Have added @KaiUsher and/or @EllisHenderson for review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of #3898, #3403, and #3136 which aim to build a test suite for the Angular application, this PR fixes all TSLint errors in the Angular template as a part of issue #4006. When running
npm run lint, you will still receive errors, but only for the.spec.tsfiles, which will need to be tended to when tests are written.This PR contains only syntactical modifications, and does not alter the logic or function of the code in any way.
A large part of the template code could have been fixed by smushing everything into one line when using EJS for loops, but for ease of future development and readability, I have kept these EJS template loops as they were, and included
<%_ _%>EJS tags to remove white-space in the generated application.