This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Add initial Grid Schema Protos #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema and Track and Trace both have a protobuf message called PropertyValue. This causes an issue when generating the protobufs. Since Track and Trace will be updated to use Grid Schema once it is complete, this commit temporarily renames Track and Trace's PropertyValue to TrackAndTracePropertyValue so they can both build at the same time. Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
agunde406
requested review from
boydjohnson,
annechenette,
davececchi,
dcmiddle,
dplumb94,
jsmitchell,
peterschwarz,
rbuysse,
RyanLassigBanks and
vaporos
as code owners
davececchi
approved these changes
Mar 19, 2019
agunde406
force-pushed
the
agunde406-schema-protos
branch
from
b227228
to
d893bbb
Compare
Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
agunde406
force-pushed
the
agunde406-schema-protos
branch
from
d893bbb
to
b7ae6f6
Compare
peterschwarz
approved these changes
Mar 19, 2019
vaporos
approved these changes
Mar 19, 2019
ameliabradley
pushed a commit
to ameliabradley/grid
that referenced
this pull request
Jul 29, 2022
…anopy-element-check Check if sideNav is in dom before hiding it
ameliabradley
pushed a commit
to ameliabradley/grid
that referenced
this pull request
Jul 29, 2022
Disable Travis CI builds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required temporarily renaming Track and Trace's PropertyValue to TrackAndTracePropertyValue because protobuf would not build two instances of PropertyValue. We plan to update Track And Trace to use Grid Schema once it has been completed.