Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Update the README.md to reflect Grid (was: Sawtooth Supply Chain) #2

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

vaporos
Copy link
Contributor

@vaporos vaporos commented Jan 17, 2019

Signed-off-by: Shawn T. Amundson amundson@bitwise.io

README.md Outdated

![Hyperledger Sawtooth](images/sawtooth_logo_light_blue-small.png)
Grid is a WebAssembly-based project for building supply chain solutions. It
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's against best practices to turn a product name (a noun) into an hyphenated adjective (WebAssembly-based). Instead, I recommend "... a project based on WebAssembly for building...".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, consider adding a link to WebAssembly.org.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just pulled from the proposal. I removed WebAssembly-based, as it places too much of the emphasis on a specific underlying technology.

README.md Outdated
please see its
[sawtooth-core repo](https://github.com/hyperledger/sawtooth-core) or its
[published docs](https://sawtooth.hyperledger.org/docs/).
Documentation for how to run and extend Grid is available here:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "here:" to "at" (without the colon).

(Best practice for online writing: Do not use "here" to introduce a link or act as the link text.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I suggest changing "Documentation for" to "Information on" (to avoid duplicating the word "Documentation).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated
- [Manually Building Generated Files](#manually-building-generated-files)
- [Documentation](#documentation)
- [License](#license)
This Hyperledger project is in _Incubation_. It was proposed to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to a lower-case "i" for "incubation".

Copy link
Contributor

@annechenette annechenette Jan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that Hyperledger's own project life cycle document uses a capital I (and italics) for Incubation, even in the middle of a sentence. Although I disagree with their style choice, you could choose to follow their convention for this term. Or you could follow best practices for writing and grammar. I leave this decision up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated
- [Documentation](#documentation)
- [License](#license)
This Hyperledger project is in _Incubation_. It was proposed to the
community and documented [here](https://docs.google.com/document/d/1b6ES0bKUK30E2iZizy3vjVEhPn7IvsW5buDo7nFXBE0/edit).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the link text from "here" to something descriptively specific, such as:

"in this [Hyperledger Grid Proposal](..."

Also, should the link to the doc go straight to edit mode? I recommend deleting /edit from the URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not strip /edit off the URL. This just causes an additional redirect.

README.md Outdated
- [License](#license)
This Hyperledger project is in _Incubation_. It was proposed to the
community and documented [here](https://docs.google.com/document/d/1b6ES0bKUK30E2iZizy3vjVEhPn7IvsW5buDo7nFXBE0/edit).
Information on what _Incubation_ entails can be found in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/entails/means/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if you change to "incubation" above, make the same change here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated
[Apache License Version 2.0](LICENSE) software license.

Hyperledger Sawtooth Supply Chain documentation in the [docs](docs)
Hyperledger Grid documentation in the [docs](docs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence seems malformed at first. To smooth it out, I'd start this sentence with "The".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated

![Hyperledger Sawtooth](images/sawtooth_logo_light_blue-small.png)
Grid is a WebAssembly-based project for building supply chain solutions. It
Copy link
Contributor

@annechenette annechenette Jan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say "Hyperledger Grid" instead of "Grid" here and elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this, though I'm not sure I agree with it, as it changes the tone.

Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
@vaporos vaporos merged commit 9273e4e into hyperledger-archives:master Jan 18, 2019
ameliabradley pushed a commit to ameliabradley/grid that referenced this pull request Jul 29, 2022
Merge splinter into canopyjs repo and remove unnecessary files
ameliabradley pushed a commit to ameliabradley/grid that referenced this pull request Jul 29, 2022
Merge splinter into saplingjs repo and remove unnecessary files
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants