-
Notifications
You must be signed in to change notification settings - Fork 98
Update the README.md to reflect Grid (was: Sawtooth Supply Chain) #2
Conversation
README.md
Outdated
|
||
![Hyperledger Sawtooth](images/sawtooth_logo_light_blue-small.png) | ||
Grid is a WebAssembly-based project for building supply chain solutions. It |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's against best practices to turn a product name (a noun) into an hyphenated adjective (WebAssembly-based). Instead, I recommend "... a project based on WebAssembly for building...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, consider adding a link to WebAssembly.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just pulled from the proposal. I removed WebAssembly-based, as it places too much of the emphasis on a specific underlying technology.
README.md
Outdated
please see its | ||
[sawtooth-core repo](https://github.com/hyperledger/sawtooth-core) or its | ||
[published docs](https://sawtooth.hyperledger.org/docs/). | ||
Documentation for how to run and extend Grid is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "here:" to "at" (without the colon).
(Best practice for online writing: Do not use "here" to introduce a link or act as the link text.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I suggest changing "Documentation for" to "Information on" (to avoid duplicating the word "Documentation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
- [Manually Building Generated Files](#manually-building-generated-files) | ||
- [Documentation](#documentation) | ||
- [License](#license) | ||
This Hyperledger project is in _Incubation_. It was proposed to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to a lower-case "i" for "incubation".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that Hyperledger's own project life cycle document uses a capital I (and italics) for Incubation, even in the middle of a sentence. Although I disagree with their style choice, you could choose to follow their convention for this term. Or you could follow best practices for writing and grammar. I leave this decision up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
- [Documentation](#documentation) | ||
- [License](#license) | ||
This Hyperledger project is in _Incubation_. It was proposed to the | ||
community and documented [here](https://docs.google.com/document/d/1b6ES0bKUK30E2iZizy3vjVEhPn7IvsW5buDo7nFXBE0/edit). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the link text from "here" to something descriptively specific, such as:
"in this [Hyperledger Grid Proposal](..."
Also, should the link to the doc go straight to edit mode? I recommend deleting /edit
from the URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not strip /edit off the URL. This just causes an additional redirect.
README.md
Outdated
- [License](#license) | ||
This Hyperledger project is in _Incubation_. It was proposed to the | ||
community and documented [here](https://docs.google.com/document/d/1b6ES0bKUK30E2iZizy3vjVEhPn7IvsW5buDo7nFXBE0/edit). | ||
Information on what _Incubation_ entails can be found in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/entails/means/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if you change to "incubation" above, make the same change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
[Apache License Version 2.0](LICENSE) software license. | ||
|
||
Hyperledger Sawtooth Supply Chain documentation in the [docs](docs) | ||
Hyperledger Grid documentation in the [docs](docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence seems malformed at first. To smooth it out, I'd start this sentence with "The".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
|
||
![Hyperledger Sawtooth](images/sawtooth_logo_light_blue-small.png) | ||
Grid is a WebAssembly-based project for building supply chain solutions. It |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Say "Hyperledger Grid" instead of "Grid" here and elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this, though I'm not sure I agree with it, as it changes the tone.
Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
0cd79d3
to
9832f94
Compare
Merge splinter into canopyjs repo and remove unnecessary files
Merge splinter into saplingjs repo and remove unnecessary files
Signed-off-by: Shawn T. Amundson amundson@bitwise.io