This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Add GridConfig for gridd #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a ConfigurationError, which will be used to propagate any issues that occur at configuration time. Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
A GridConfig can be created via a Builder. The intent of the GridConfig builder is to join in values from various sources: default values and cli args to start. Future commits may include joining values from a configuration file. This initial version includes values for the connect (i.e. validator endpoint) and the logging level). Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
Replace the use of arg matches directly with the use of grid config in main. Additionally, Add a CLI parameter for the connect endpoint. Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
peterschwarz
requested review from
agunde406,
boydjohnson,
annechenette,
davececchi,
dcmiddle,
dplumb94,
jsmitchell,
rbuysse,
RyanLassigBanks and
vaporos
as code owners
vaporos
approved these changes
Mar 25, 2019
agunde406
approved these changes
Mar 25, 2019
ameliabradley
pushed a commit
to ameliabradley/grid
that referenced
this pull request
Jul 26, 2022
…t-nodes Add partial form to select nodes for circuit proposal
ameliabradley
pushed a commit
to ameliabradley/grid
that referenced
this pull request
Jul 29, 2022
…ebar Add custom icon support to sidebar
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GridConfig and GridConfigBuilder to transform CLI args (and future configuration files) into a configuration object. Defaults are all managed via the builder.