This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Change default validator and rest_api addresses #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloaverona
requested review from
agunde406,
boydjohnson,
annechenette,
davececchi,
dcmiddle,
dplumb94,
jsmitchell,
peterschwarz,
rbuysse,
RyanLassigBanks and
vaporos
as code owners
To use `localhost` as part of an address does not work with Actix. This updates the default validator and REST API endpoints to use 127.0.0.1 instead. Signed-off-by: Eloá Franca Verona <eloafran@bitwise.io>
eloaverona
force-pushed
the
fix_restapi_bug
branch
from
f0460d6
to
73c2ee3
Compare
eloaverona
changed the title
Updates docker-compose yaml file to expose the daemon rest-api port Signed-off-by: Eloá Franca Verona <eloafran@bitwise.io>
peterschwarz
approved these changes
Mar 27, 2019
agunde406
approved these changes
Mar 27, 2019
ameliabradley
pushed a commit
to ameliabradley/grid
that referenced
this pull request
Jul 29, 2022
Add additional .env file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use
localhostas part of an address does not work with Actix. It compiles but when you try to send a request, there's no response. I found no documentation on this problem, but all Actix examples use127.0.0.1rather than localhost. This PR updates updates the default validatorand REST API endpoints to use
127.0.0.1instead oflocalhost.