Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-google-sm): complete request handler and endpoints #1097

Closed
jagpreetsinghsasan opened this issue Jun 28, 2021 · 2 comments · Fixed by #1188
Closed

feat(keychain-google-sm): complete request handler and endpoints #1097

jagpreetsinghsasan opened this issue Jun 28, 2021 · 2 comments · Fixed by #1188
Assignees
@twiggins120
Labels
good-first-issue Good for newcomers good-first-issue-100-introductory Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.

Comments

@jagpreetsinghsasan
Copy link
Contributor

jagpreetsinghsasan commented Jun 28, 2021 •
edited by petermetz
Loading

Description

As a developer, I want to complete the code to enable the endpoints
get-keychain-entry
set-keychain-entry
delete-keychain-entry (or maybe use set-keychain-entry with tags for deletion)
Also, write tests that use the API client instead of the plugin instance directly.

Acceptance Criteria

  1. Update openapi.json at packages/cactus-plugin-keychain-google-sm/src/main/json/openapi.json
  2. Update the endpoints at packages/cactus-plugin-keychain-google-sm/src/main/typescript/webservices
  3. UPDATE: We do not need the remote adapter unless the plugin is implemented in a non-NodeJS language
  4. Update the test code at packages/cactus-plugin-keychain-google-sm/src/test/typescript/integration/plugin-keychain-google-sm.test.ts

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy @petermetz @TonyRowntree @travis-payne
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Jun 28, 2021
Merged
@petermetz petermetz added Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. good-first-issue Good for newcomers good-first-issue-100-introductory labels Jul 8, 2021
@petermetz
Copy link
Contributor

cc: @ty-lazar @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone

@twiggins120
Copy link
Contributor

I will work on this.

twiggins120 added a commit to twiggins120/cactus that referenced this issue Aug 5, 2021
@twiggins120
fixes hyperledger-cacti#1097
838d3bf 
Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
petermetz pushed a commit to twiggins120/cactus that referenced this issue Aug 5, 2021
@twiggins120 @petermetz
feat: add web services for google sm keychain hyperledger-cacti#1097
3e6924d 
fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@twiggins120 twiggins120 mentioned this issue Aug 6, 2021
Merged
twiggins120 added a commit to twiggins120/cactus that referenced this issue Aug 9, 2021
@twiggins120
feat: add web services for google sm keychain hyperledger-cacti#1097
dd91e45 
fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
decommissioned-account pushed a commit to twiggins120/cactus that referenced this issue Aug 9, 2021
@twiggins120
feat: add web services for google sm keychain hyperledger-cacti#1097
a07e850 
fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
twiggins120 added a commit to twiggins120/cactus that referenced this issue Aug 10, 2021
@twiggins120
feat: add web services for google sm keychain hyperledger-cacti#1097
80b5e41 
fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Leeyoungone pushed a commit to twiggins120/cactus that referenced this issue Aug 23, 2021
@twiggins120 @Leeyoungone
feat: add web services for google sm keychain hyperledger-cacti#1097
704b5bd 
fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Leeyoungone pushed a commit to twiggins120/cactus that referenced this issue Aug 24, 2021
@twiggins120 @Leeyoungone
feat: add web services for google sm keychain hyperledger-cacti#1097
2a05965 
fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Aug 25, 2021
@twiggins120 @Leeyoungone
feat: add web services for google sm keychain hyperledger-cacti#1097
559f5bf 
fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Aug 25, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
8da0ecb 
Fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 1, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
aff7426 
Fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 2, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
7d8d6e9 
Fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 3, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
b7dcf39 
Fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 15, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
0992d06 
Fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 16, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
f78f33c 
Fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 16, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
7b9b2f1 
Fixes hyperledger-cacti#1097

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 21, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
396312f 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 21, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
018cef5 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 23, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
a1da81d 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to twiggins120/cactus that referenced this issue Sep 23, 2021
@Leeyoungone
feat(keychain-google-sm): complete request handler and endpoints
4050410 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
petermetz pushed a commit to twiggins120/cactus that referenced this issue Oct 1, 2021
@Leeyoungone @petermetz
feat(keychain-google-sm): complete request handler and endpoints
e87f49f 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to twiggins120/cactus that referenced this issue Oct 1, 2021
@Leeyoungone @petermetz
feat(keychain-google-sm): complete request handler and endpoints
7d3a8e6 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to twiggins120/cactus that referenced this issue Oct 2, 2021
@Leeyoungone @petermetz
feat(keychain-google-sm): complete request handler and endpoints
8009514 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to twiggins120/cactus that referenced this issue Oct 5, 2021
@Leeyoungone @petermetz
feat(keychain-google-sm): complete request handler and endpoints
bdeeffa 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit that referenced this issue Oct 6, 2021
@Leeyoungone @petermetz
feat(keychain-google-sm): complete request handler and endpoints
9c7bab5 
Fixes #1097
Depends on #1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@Leeyoungone @RafaelAPB
feat(keychain-google-sm): complete request handler and endpoints
cebb380 
Fixes hyperledger-cacti#1097
Depends on hyperledger-cacti#1349

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Tyler Lazar <tyler.a.lazar@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twiggins120 twiggins120

Labels
good-first-issue Good for newcomers good-first-issue-100-introductory Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(keychain-google-sm): complete request handler and endpoints #1097 twiggins120/cactus
3 participants
@petermetz @jagpreetsinghsasan @twiggins120