Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cmd-socketio-server): cmd-socketio-server Verifier test adjustments #1573

Closed
outSH opened this issue Nov 24, 2021 · 0 comments · Fixed by #1574
Closed

refactor(cmd-socketio-server): cmd-socketio-server Verifier test adjustments #1573

outSH opened this issue Nov 24, 2021 · 0 comments · Fixed by #1574
Labels
enhancement New feature or request

Comments

@outSH
Copy link
Contributor

outSH commented Nov 24, 2021

Some fixes in cmd-socketio-server are needed to develop unit tests for Verifier class:

  • Fix warnings triggered by the strict flag from root of the project
  • Format the code according to cactus/.prettierrc.js
  • Minor fixes (mostly log writing)
  • Dependency injection for VerifierAuthentication.verify
  • Hangup bug in sendSyncRequest
@outSH outSH added the enhancement New feature or request label Nov 24, 2021
outSH added a commit to outSH/cactus that referenced this issue Nov 24, 2021
@outSH
refactor: cmd-socketio-server Verifier test adjustments
4e431c3 
Fix warnings triggered by the strict flag, format the code according to
cactus/.prettierrc.js, minor fixes (mostly in log writing), dependency
injection for VerifierAuthentication.verify.

Closes: hyperledger-cacti#1573
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Nov 24, 2021
@outSH
refactor(cmd-socketio-server): cmd-socketio-server Verifier test adju…
91f67fb 
…stments

Fix warnings triggered by the strict flag, format the code according to
cactus/.prettierrc.js, minor fixes (mostly in log writing), dependency
injection for VerifierAuthentication.verify.

Closes: hyperledger-cacti#1573
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this issue Nov 24, 2021
Merged
outSH added a commit to outSH/cactus that referenced this issue Nov 24, 2021
@outSH
refactor(cmd-socketio-server): cmd-socketio-server Verifier test adju…
0da3f40 
…stments

Fix warnings triggered by the strict flag, format the code according to
cactus/.prettierrc.js, minor fixes (mostly in log writing), dependency
injection for VerifierAuthentication.verify.

Closes: hyperledger-cacti#1573
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Nov 25, 2021
@outSH
refactor(cmd-socketio-server): cmd-socketio-server Verifier test adju…
888e9d9 
…stments

Fix warnings triggered by the strict flag, format the code according to
cactus/.prettierrc.js, minor fixes (mostly in log writing), dependency
injection for VerifierAuthentication.verify.

Closes: hyperledger-cacti#1573
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Nov 25, 2021
@outSH
refactor(cmd-socketio-server): cmd-socketio-server Verifier test adju…
a88f24c 
…stments

Fix warnings triggered by the strict flag, format the code according to
cactus/.prettierrc.js, minor fixes (mostly in log writing), dependency
injection for VerifierAuthentication.verify.

Closes: hyperledger-cacti#1573
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
takeutak pushed a commit that referenced this issue Nov 26, 2021
@outSH @takeutak
refactor(cmd-socketio-server): cmd-socketio-server Verifier test adju…
a7bcbd2 
…stments

Fix warnings triggered by the strict flag, format the code according to
cactus/.prettierrc.js, minor fixes (mostly in log writing), dependency
injection for VerifierAuthentication.verify.

Closes: #1573
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this issue Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(cmd-socketio-server): cmd-socketio-server Verifier test adjustments outSH/cactus
1 participant
@outSH