-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(test-tooling): fix flaky rustc-container-target-nodejs.test #1646
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
Developer_Experience
Flaky-Test-Automation
Issues related to test stability (which is a long running issue that can never fully be solved)
good-first-issue
Good for newcomers
good-first-issue-400-expert
P4
Priority 4: Low
Tests
Anything related to tests be that automatic or manual, integration or unit, etc.
Comments
Inspecting the cargo / wasm-pack build output logs with the debugger offered some clues: wasmPackBuildOut
'[INFO]: Checking for the Wasm target...
info: �(Bdownloading component 'rust-std' for 'wasm32-unknown-unknown'
info: �(Binstalling component 'rust-std' for 'wasm32-unknown-unknown'
info: �(Busing up to 500.0 MiB of RAM to unpack components
6.9 MiB / 13.2 MiB ( 53 %) 0 B/s in 1s ETA: Unknown
9.8 MiB / 13.2 MiB ( 74 %) 6.9 MiB/s in 2s ETA: 0s
13.2 MiB / 13.2 MiB (100 %) 4.9 MiB/s in 2s ETA: 0s
[INFO]: Compiling to Wasm...
Compiling proc-macro2 v1.0.36
Compiling unicode-xid v0.2.2
Compiling log v0.4.14
Compiling wasm-bindgen-shared v0.2.78
Compiling syn v1.0.85
Compiling cfg-if v1.0.0
Compiling lazy_static v1.4.0
Compiling bumpalo v3.9.1
�[38;5;9merror[E0658]: arbitrary expressions in key-value attributes are unstable
�[38;5;12m--> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/bumpalo-3.9.1/src/lib.rs:1:10
�[38;5;12m|
�[38;5;12m1 �[38;5;12m| #![doc = include_str!("../README.md")]
�[38;5;12m| �[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^
�[38;5;12m|
�[38;5;12m= note: see issue #78835 <https://github.com/rust-lang/rust/issues/78835> for more information
Compiling wasm-bindgen v0.2.78
�[38;5;9merror: aborting due to previous error
For more information about this error, try `rustc --explain E0658`.
error: could not compile `bumpalo`
To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
Error: Compiling your crate to WebAssembly failed
Caused by: failed to execute `cargo build`: exited with exit code: 101
full command: "cargo" "build" "--lib" "--release" "--target" "wasm32-unknown-unknown"
'
|
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Jan 12, 2022
The problem was that the Rust compiler version we were using (v1.52.x) seem to have gotten outdated and it would no longer work with wasm-pack. To provide a fix I upgraded the base image of the container to come with Rust v1.57.x and now the build error[1] is no longer present and the test case is passing with the new image that was pushed to ghcr.io. The image tag this was pushed as is: ghcr.io/hyperledger/cactus-rust-compiler:2022-01-12-15d4793c---fix-1646 which is now also the default tag that the RustcContainer class uses in the test-tooling package. [1]: ```sh Compiling bumpalo v3.9.1 �[38;5;9merror[E0658]: arbitrary expressions in key-value attributes are unstable �[38;5;12m--> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/bumpalo-3.9.1/src/lib.rs:1:10 �[38;5;12m| �[38;5;12m1 �[38;5;12m| #![doc = include_str!("../README.md")] �[38;5;12m| �[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^ �[38;5;12m| �[38;5;12m= note: see issue #78835 <rust-lang/rust#78835> for more information Compiling wasm-bindgen v0.2.78 �[38;5;9merror: aborting due to previous error For more information about this error, try `rustc --explain E0658`. error: could not compile `bumpalo` ``` Fixes hyperledger-cacti#1646 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this issue
Jan 13, 2022
The problem was that the Rust compiler version we were using (v1.52.x) seem to have gotten outdated and it would no longer work with wasm-pack. To provide a fix I upgraded the base image of the container to come with Rust v1.57.x and now the build error[1] is no longer present and the test case is passing with the new image that was pushed to ghcr.io. The image tag this was pushed as is: ghcr.io/hyperledger/cactus-rust-compiler:2022-01-12-15d4793c---fix-1646 which is now also the default tag that the RustcContainer class uses in the test-tooling package. [1]: ```sh Compiling bumpalo v3.9.1 �[38;5;9merror[E0658]: arbitrary expressions in key-value attributes are unstable �[38;5;12m--> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/bumpalo-3.9.1/src/lib.rs:1:10 �[38;5;12m| �[38;5;12m1 �[38;5;12m| #![doc = include_str!("../README.md")] �[38;5;12m| �[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^ �[38;5;12m| �[38;5;12m= note: see issue #78835 <rust-lang/rust#78835> for more information Compiling wasm-bindgen v0.2.78 �[38;5;9merror: aborting due to previous error For more information about this error, try `rustc --explain E0658`. error: could not compile `bumpalo` ``` Fixes #1646 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez
pushed a commit
to aldousalvarez/cactus
that referenced
this issue
Jan 19, 2022
The problem was that the Rust compiler version we were using (v1.52.x) seem to have gotten outdated and it would no longer work with wasm-pack. To provide a fix I upgraded the base image of the container to come with Rust v1.57.x and now the build error[1] is no longer present and the test case is passing with the new image that was pushed to ghcr.io. The image tag this was pushed as is: ghcr.io/hyperledger/cactus-rust-compiler:2022-01-12-15d4793c---fix-1646 which is now also the default tag that the RustcContainer class uses in the test-tooling package. [1]: ```sh Compiling bumpalo v3.9.1 �[38;5;9merror[E0658]: arbitrary expressions in key-value attributes are unstable �[38;5;12m--> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/bumpalo-3.9.1/src/lib.rs:1:10 �[38;5;12m| �[38;5;12m1 �[38;5;12m| #![doc = include_str!("../README.md")] �[38;5;12m| �[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^ �[38;5;12m| �[38;5;12m= note: see issue #78835 <rust-lang/rust#78835> for more information Compiling wasm-bindgen v0.2.78 �[38;5;9merror: aborting due to previous error For more information about this error, try `rustc --explain E0658`. error: could not compile `bumpalo` ``` Fixes hyperledger-cacti#1646 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez
pushed a commit
to aldousalvarez/cactus
that referenced
this issue
Jan 19, 2022
The problem was that the Rust compiler version we were using (v1.52.x) seem to have gotten outdated and it would no longer work with wasm-pack. To provide a fix I upgraded the base image of the container to come with Rust v1.57.x and now the build error[1] is no longer present and the test case is passing with the new image that was pushed to ghcr.io. The image tag this was pushed as is: ghcr.io/hyperledger/cactus-rust-compiler:2022-01-12-15d4793c---fix-1646 which is now also the default tag that the RustcContainer class uses in the test-tooling package. [1]: ```sh Compiling bumpalo v3.9.1 �[38;5;9merror[E0658]: arbitrary expressions in key-value attributes are unstable �[38;5;12m--> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/bumpalo-3.9.1/src/lib.rs:1:10 �[38;5;12m| �[38;5;12m1 �[38;5;12m| #![doc = include_str!("../README.md")] �[38;5;12m| �[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^ �[38;5;12m| �[38;5;12m= note: see issue #78835 <rust-lang/rust#78835> for more information Compiling wasm-bindgen v0.2.78 �[38;5;9merror: aborting due to previous error For more information about this error, try `rustc --explain E0658`. error: could not compile `bumpalo` ``` Fixes hyperledger-cacti#1646 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
Developer_Experience
Flaky-Test-Automation
Issues related to test stability (which is a long running issue that can never fully be solved)
good-first-issue
Good for newcomers
good-first-issue-400-expert
P4
Priority 4: Low
Tests
Anything related to tests be that automatic or manual, integration or unit, etc.
Marking this as a good first issue because most likely it's due to some race condition
in the code that someone with sufficient general knowledge of programming should be
able to debug with little knowledge/understanding about the architecture of Cactus
as a whole.
The path of the test file is:
packages/cactus-test-tooling/src/test/typescript/integration/rustc-container/rustc-container-target-nodejs.test.ts
Logs
Full CI logs archive: logs_11827.zip
It passes fine most of the time, but every now and then it fails with logs like this:
Version
1.0.0-rc.3
The text was updated successfully, but these errors were encountered: