Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only fabric-all-in-one image, remove reduntant fabric testnets #1753

Closed
outSH opened this issue Jan 11, 2022 · 0 comments · Fixed by #1754
Closed

Use only fabric-all-in-one image, remove reduntant fabric testnets #1753

outSH opened this issue Jan 11, 2022 · 0 comments · Fixed by #1754
Labels
enhancement New feature or request

Comments

@outSH
Copy link
Contributor

outSH commented Jan 11, 2022

There's no need to maintain multiple farbic (FabCar) testnets for test purposes, all code should work with fabric-all-in-one image. Changes are needed in:

  • cactus-plugin-ledger-connector-fabric-socketio
  • cartrade
  • discounted-cartrade
@outSH outSH added the enhancement New feature or request label Jan 11, 2022
outSH added a commit to outSH/cactus that referenced this issue Jan 11, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jan 11, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jan 11, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jan 11, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jan 11, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jan 14, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jan 17, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit that referenced this issue Jan 18, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: #1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
aldousalvarez pushed a commit to aldousalvarez/cactus that referenced this issue Jan 19, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez pushed a commit to aldousalvarez/cactus that referenced this issue Jan 19, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez pushed a commit to aldousalvarez/cactus that referenced this issue Jan 19, 2022
…m fabric14-fabcar-testnet

Remove obsolete fabric  fabric14-fabcar-testnet fabric14-testnet, use
only fabric-all-in-one for all purposes for all test / sample app
purposes. Add helper scripts from fabric-sample that are used during
cartrade setup phase (I've decided it's better to keep them in repo than
increasing the size of fabric-all-in-one image). Upgrade of fabcar
network (from 1.4.1 to 1.4.8) triggered multiple changes in
fabric-socketio validator, since fabcar nodes (peers, orderer) use TLS
and require different setup, additionaly done some refactors and fixes
in the validator. Update the cartrade and discounted-cartrade sample
apps to work with the new setup, refreshed scripts can be used to ease
up the setup process.

Closes: hyperledger-cacti#1753
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant