Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(cmd-api-server): auto-publishing installs old npm packages #1951

Open
petermetz opened this issue Mar 24, 2022 · 6 comments · Fixed by #2180 or #2194
Open

ci(cmd-api-server): auto-publishing installs old npm packages #1951

petermetz opened this issue Mar 24, 2022 · 6 comments · Fixed by #2180 or #2194
Assignees
@petermetz
Labels
API_Server bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience
Milestone
vT.B.D

Comments

@petermetz
Copy link
Contributor

petermetz commented Mar 24, 2022 •
edited
Loading

This is a prerequisite for atomic release issuance: #451

Summary

The order of publishing for the 1.0.0 for example happened this way:

  1. Release PR gets merged
  2. GitHub workflows build the container images and publish them
  3. In the above step the npm packages are installed with version as "latest" by default, but at this point the npm publishing hasn't happened yet and so the 1.0.0-rc.3 npm package is getting installed into the 1.0.0 container image...
  4. npm publishing happens (Peter does this manually as of right now which is the problem)

Solution

  1. Make npm publishing an automated workflow as well and then ensure that the dependency is declaratively expressed in the workflow yaml of the container publishing file so that it is guaranteed that the npm publishing succeeds first and only then the container image build+publishing happens.
  2. Ensure that the container image publishing uses explicit npm package versions instead of "latest" so that next time if this issue arises it just fails loud and proud instead of silently and then ending up causing more trouble that way.
@petermetz petermetz added API_Server bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience P1 Priority 1: Highest labels Mar 24, 2022
@petermetz petermetz self-assigned this Mar 24, 2022
@petermetz petermetz mentioned this issue Mar 24, 2022
Closed
@petermetz petermetz mentioned this issue Oct 11, 2022
Closed
@johnhomantaring
Copy link
Contributor

you can assign this to me @petermetz

@johnhomantaring
Copy link
Contributor

just a clarification @petermetz the automated workflow for npm publishing will be triggered upon push right?

@petermetz
Copy link
Contributor Author

you can assign this to me @petermetz

Thank you @johnhomantaring , assigned it just now.

@petermetz
Copy link
Contributor Author

just a clarification @petermetz the automated workflow for npm publishing will be triggered upon push right?

@johnhomantaring No it gets triggered by the tagging (step 4 explained in the parent issue)

@petermetz petermetz mentioned this issue Oct 31, 2022
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Oct 31, 2022
@petermetz
build: fix release automation
dfb90a4 
Adds a GitHub workflow yaml file that executes the
publish script.
This workflow only gets triggered when a git tag has been
created that starts with the letter v (as in version).

Fixes hyperledger-cacti#1951
Fixes hyperledger-cacti#2054
Fixes hyperledger-cacti#2175

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 2, 2022
@petermetz
build: fix release automation
3b477c2 
Adds a GitHub workflow yaml file that executes the
publish script.
This workflow only gets triggered when a git tag has been
created that starts with the letter v (as in version).

Fixes hyperledger-cacti#1951
Fixes hyperledger-cacti#2054
Fixes hyperledger-cacti#2175

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 2, 2022
@petermetz
build: fix release automation
6c3f9c7 
Adds a GitHub workflow yaml file that executes the
publish script.
This workflow only gets triggered when a git tag has been
created that starts with the letter v (as in version).

Fixes hyperledger-cacti#1951
Fixes hyperledger-cacti#2054
Fixes hyperledger-cacti#2175

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Nov 2, 2022
@petermetz
build: fix release automation
2fec226 
Adds a GitHub workflow yaml file that executes the
publish script.
This workflow only gets triggered when a git tag has been
created that starts with the letter v (as in version).

Fixes #1951
Fixes #2054
Fixes #2175

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz
Copy link
Contributor Author

Re-opening until we can fix the release automation issues.

@petermetz petermetz reopened this Nov 9, 2022
@petermetz petermetz mentioned this issue Nov 9, 2022
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Nov 9, 2022
@petermetz
build: fix release automation - try #2
c0a374b 
A second attempt at fixing the release automation.

The missing piece was that some of the Indy SDK dependencies
were not installed by default and we forgot to run the ci.sh
script to take care of that within this workflow action.

With this fix now we have an additional step in the action which
takes care of installing the OS level build dependencies for
the project.

Fixes hyperledger-cacti#1951
Fixes hyperledger-cacti#2069
Fixes hyperledger-cacti#2175

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Nov 10, 2022
@petermetz
build: fix release automation - try #2
d94abe7 
A second attempt at fixing the release automation.

The missing piece was that some of the Indy SDK dependencies
were not installed by default and we forgot to run the ci.sh
script to take care of that within this workflow action.

With this fix now we have an additional step in the action which
takes care of installing the OS level build dependencies for
the project.

Fixes #1951
Fixes #2069
Fixes #2175

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz
Copy link
Contributor Author

Re-opening AGAIN until we can fix the release automation issues.

@petermetz petermetz reopened this Nov 23, 2022
@petermetz petermetz mentioned this issue Jul 24, 2023
Closed
@petermetz petermetz added this to the v2.0.0 milestone Jul 5, 2024
@petermetz petermetz modified the milestones: v2.0.0, vT.B.D Sep 9, 2024
@petermetz petermetz removed the P1 Priority 1: Highest label Sep 9, 2024
@petermetz petermetz moved this from In Progress to Blocked in Cacti_Scrum_Project_v2_Release Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
API_Server bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience
Projects
None yet
Milestone
vT.B.D
2 participants
@petermetz @johnhomantaring