Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(geth-all-in-one): improve geth helper class tests coverage #2579

Closed
outSH opened this issue Jul 25, 2023 · 0 comments · Fixed by #2906
Closed

test(geth-all-in-one): improve geth helper class tests coverage #2579

outSH opened this issue Jul 25, 2023 · 0 comments · Fixed by #2906
Labels
enhancement New feature or request

Comments

@outSH
Copy link
Contributor

outSH commented Jul 25, 2023

Features to be tested:

  • fullContainerImageName test
  • className test
  • container/web3 throws when not started, works after
  • getContainerStatus (check if healthy after test start)
  • dont test useRunningLedger or omitPull options
  • createEthTestAccount test
  • newEthPersonalAccount test
    • Refactor to use Clef instead of eth.personal
  • transferAssetFromCoinbase test
  • deployContract test
  • getRpcApiHttpHost / getRpcApiWebSocketHost - valid URL returned

@rwat17
@outSH outSH added the enhancement New feature or request label Jul 25, 2023
@outSH outSH mentioned this issue Jul 25, 2023
Merged
rwat17 added a commit to rwat17/cactus that referenced this issue Jul 28, 2023
@rwat17
test: add test for geth-test-ledger
b58032d 
-add tests for geth-test-ledger
-fix small errors in GethTestLedger class

Closes: hyperledger-cacti#2579
Depends on: hyperledger-cacti#2577

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
@rwat17 rwat17 mentioned this issue Jul 28, 2023
Closed
rwat17 added a commit to rwat17/cactus that referenced this issue Aug 1, 2023
@rwat17
test: add test for geth-test-ledger
6ef8f7f 
-add tests for geth-test-ledger
-fix small errors in GethTestLedger class

Closes: hyperledger-cacti#2579
Depends on: hyperledger-cacti#2577

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Aug 9, 2023
@rwat17
test: add test for geth-test-ledger
e9d6694 
-add tests for geth-test-ledger
-fix small errors in GethTestLedger class

Closes: hyperledger-cacti#2579
Depends on: hyperledger-cacti#2577

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
petermetz pushed a commit to rwat17/cactus that referenced this issue Aug 15, 2023
@rwat17 @petermetz
test: add test for geth-test-ledger
17eef7f 
-add tests for geth-test-ledger
-fix small errors in GethTestLedger class

Closes: hyperledger-cacti#2579
Depends on: hyperledger-cacti#2577

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Aug 17, 2023
@rwat17
test: add test for geth-test-ledger
4facda4 
-add tests for geth-test-ledger
-fix small errors in GethTestLedger class

Closes: hyperledger-cacti#2579
Depends on: hyperledger-cacti#2577

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Aug 17, 2023
@rwat17
test: add test for geth-test-ledger
e1b93b3 
-add tests for geth-test-ledger
-fix small errors in GethTestLedger class

Closes: hyperledger-cacti#2579
Depends on: hyperledger-cacti#2577

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com
outSH added a commit to outSH/cactus that referenced this issue Nov 24, 2023
@outSH
test(geth-test-ledger): add basic tests
ebd624c 
- Add test suite for geth-test-ledger package.
- Add new test suit to CI
- It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements.

Closes: hyperledger-cacti#2579

Co-authored-by: Tomasz Awramski <tomasz.awramski@fujitsu.com

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Nov 24, 2023
@outSH
test(geth-test-ledger): add basic tests
ccca00f 
- Add test suite for geth-test-ledger package.
- Add new test suit to CI
- It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements.

Closes: hyperledger-cacti#2579

Co-authored-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this issue Nov 24, 2023
Merged
5 tasks
outSH added a commit to outSH/cactus that referenced this issue Dec 12, 2023
@outSH
test(geth-test-ledger): add basic tests
ab080ef 
- Add test suite for geth-test-ledger package.
- Add new test suit to CI
- It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements.

Closes: hyperledger-cacti#2579

Co-authored-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Dec 18, 2023
@outSH
test(geth-test-ledger): add basic tests
d04fb6b 
- Add test suite for geth-test-ledger package.
- Add new test suit to CI
- It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements.

Closes: hyperledger-cacti#2579

Co-authored-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Dec 19, 2023
@outSH
test(geth-test-ledger): add basic tests
5742f67 
- Add test suite for geth-test-ledger package.
- Add new test suit to CI
- It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements.
- Run codegen, update missing deps, sort package.json,
    fix type in socketio-test-setup-helpers, to fix some CI.

Closes: hyperledger-cacti#2579

Co-authored-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Dec 19, 2023
@outSH
test(geth-test-ledger): add basic tests
3827001 
- Add test suite for geth-test-ledger package.
- Add new test suit to CI
- It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements.
- Run codegen, update missing deps, sort package.json,
    fix type in socketio-test-setup-helpers, to fix some CI.

Closes: hyperledger-cacti#2579

Co-authored-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit that referenced this issue Dec 19, 2023
@outSH
test(geth-test-ledger): add basic tests
ff3eb8c 
- Add test suite for geth-test-ledger package.
- Add new test suit to CI
- It was initially proposed in #2588, I've added some cleanups and improvements.
- Run codegen, update missing deps, sort package.json,
    fix type in socketio-test-setup-helpers, to fix some CI.

Closes: #2579

Co-authored-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@outSH @sandeepnRES
test(geth-test-ledger): add basic tests
275311e 
- Add test suite for geth-test-ledger package.
- Add new test suit to CI
- It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements.
- Run codegen, update missing deps, sort package.json,
    fix type in socketio-test-setup-helpers, to fix some CI.

Closes: hyperledger-cacti#2579

Co-authored-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@outSH