Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json #2693

Closed
petermetz opened this issue Sep 16, 2023 · 1 comment · Fixed by #3463
Closed

refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json #2693

petermetz opened this issue Sep 16, 2023 · 1 comment · Fixed by #3463
Assignees
@aldousalvarez
Labels
API_Server Breaking_V2 Changes that can only be made with the release of v3.0.0 due to them being breaking changes. P2 Priority 2: High Security Related to existing or potential security vulnerabilities
Milestone
v2.1.0

Comments

@petermetz
Copy link
Contributor

Description

  1. Currently we do not specify the security section in the openapi.json files at all so this is the first thing to address
  2. Once the security sections in the spec files are consistent with the current implementation (JWTs with scopes for RBAC) then we can start refactoring the endpoint implementations in a way that uses the importer OpenAPI spec (the src/main/json/openapi.json files) security sections scope declarations instead of hardcoding it in the typescript code like it is done now)

Acceptance Criteria

  1. Test coverage added to see that the scopes are indeed getting pulled from the spec file.
@petermetz petermetz added API_Server Breaking_V2 Changes that can only be made with the release of v3.0.0 due to them being breaking changes. P2 Priority 2: High Security Related to existing or potential security vulnerabilities labels Sep 16, 2023
@petermetz petermetz added this to the v2.0.0-rc.1 milestone Sep 16, 2023
@petermetz petermetz modified the milestones: v2.0.0-rc.1, v2.0.0-rc.2 Jun 27, 2024
@petermetz petermetz modified the milestones: v2.0.0-rc.2, v2.0.0-rc.3 Jul 5, 2024
@aldousalvarez
Copy link
Contributor

Hello @jagpreetsinghsasan I would like to work on this one, Thank you

@jagpreetsinghsasan jagpreetsinghsasan moved this from Todo to In Progress in Cacti_Scrum_Project_v2_Release Jul 30, 2024
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Aug 7, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
5d2cd8e 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
@aldousalvarez aldousalvarez mentioned this issue Aug 7, 2024
Merged
5 tasks
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Aug 7, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
3321ed3 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
@aldousalvarez aldousalvarez moved this from In Progress to In review in Cacti_Scrum_Project_v2_Release Aug 7, 2024
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Aug 7, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
f44cf0c 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Aug 21, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
25c1eba 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Sep 6, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
7aeb0e1 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Sep 6, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
dade3eb 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Sep 6, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
27e4cc7 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Sep 6, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
64ae5a3 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez pushed a commit to aldousalvarez/cactus that referenced this issue Sep 6, 2024
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
83b6588 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <“aldousss.alvarez@gmail.com”>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Sep 6, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
3addc64 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Sep 6, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
4c58d17 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
petermetz pushed a commit to aldousalvarez/cactus that referenced this issue Oct 4, 2024
@aldousalvarez @petermetz
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
90f2850 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
1fa3a1b 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
2bfa838 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
6329016 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
5f6e112 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
30ec8a8 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
9149f57 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
b38aa26 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
bedd9f9 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
3974d43 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
5102f81 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
ec0065a 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
0787409 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
791e7f1 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
4bde120 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
9714a1e 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
438b005 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
3ab1da0 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
4a23b0b 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
0896415 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
141499d 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
ffd160e 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
8062375 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
125ab22 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Nov 28, 2024
@aldousalvarez
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
c6b26c7 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to aldousalvarez/cactus that referenced this issue Dec 1, 2024
@aldousalvarez @petermetz
refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json
825a7bd 
Primary Changes
----------------
1. added OAuth2 security endpoints scopes to openapi.json
2. added a test to make sure if the scopes are indeed getting
   pulled from the spec file

Fixes hyperledger-cacti#2693

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>

1. Please also refactor the third endpoint (prometheus metrics) accordingly
2. Also please extend the test case with each tokens having specific scopes
and then assert that the tokesn with the correct scopes work and the ones
that don't have the correct scopes do not even when they are otherwise
valid tokens.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@github-project-automation github-project-automation bot moved this from In review to Done in Cacti_Scrum_Project_v2_Release Dec 1, 2024
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aldousalvarez aldousalvarez

Labels
API_Server Breaking_V2 Changes that can only be made with the release of v3.0.0 due to them being breaking changes. P2 Priority 2: High Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

refactor(cmd-api-server): pull OAuth2 endpoint scopes from openapi.json aldousalvarez/cactus
3 participants
@petermetz @jagpreetsinghsasan @aldousalvarez