Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cacti-ledger-browser-react): rename as cacti-ledger-browser #3156

Closed
outSH opened this issue Mar 29, 2024 · 0 comments
Closed

feat(cacti-ledger-browser-react): rename as cacti-ledger-browser #3156

outSH opened this issue Mar 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@outSH
Copy link
Contributor

outSH commented Mar 29, 2024

Is your feature request related to a problem? Please describe.
There should be one package for cacti-ledger-browser

Describe the solution you'd like
Rename cacti-ledger-browser-react as cacti-ledger-browser, effectively remove the older solidjs based version. Make sure everything builds and works as expected.

Part of: https://github.com/hyperledger/cacti/issues/3155

@rwat17

@outSH outSH added the enhancement New feature or request label Mar 29, 2024
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 3, 2024
- delete solid.js version
- renamed packaged
- added types

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 3, 2024
- delete solid.js version
- rename package
- fix type erros

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 4, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 4, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 4, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
petermetz pushed a commit to rwat17/cactus that referenced this issue Apr 4, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 4, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 4, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 4, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 4, 2024
    - delete solid.js version
    - rename package
    - fix type erros
    - bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

    Closes: hyperledger-cacti#3156

    Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 4, 2024
    - delete solid.js version
    - rename package
    - fix type erros
    - bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

    Closes: hyperledger-cacti#3156

    Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 5, 2024
- delete solid.js version
- rename package
- fix type errors
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
outSH pushed a commit to outSH/cactus that referenced this issue Apr 8, 2024
- delete solid.js version
- rename package
- fix type errors
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 8, 2024
    - delete solid.js version
    - rename package
    - fix type erros
    - bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

    Closes: hyperledger-cacti#3156

    Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 9, 2024
    - delete solid.js version
    - rename package
    - fix type erros
    - bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

    Closes: hyperledger-cacti#3156

    Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Apr 9, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
@outSH outSH closed this as completed in 3cc33b1 Apr 9, 2024
RafaelAPB pushed a commit that referenced this issue Apr 9, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: #3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Jul 30, 2024
- delete solid.js version
- rename package
- fix type erros
- bump vite from 5.0.12 to 5.0.13 in /packages/cacti-ledger-browser-react

Closes: hyperledger-cacti#3156

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant