-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(plugin-keychain-memory): fix local imports broken due to .js extensions #3254
Labels
Flaky-Test-Automation
Issues related to test stability (which is a long running issue that can never fully be solved)
Keychain
Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Tests
Anything related to tests be that automatic or manual, integration or unit, etc.
Comments
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
May 10, 2024
Found the solution and a long discussion about it here: kulshekhar/ts-jest#1057 TLDR: The Jest resolver needs a little extra information/tweak to the config so that it can correctly handle the .js imports. Specifically this comment provided the solution which I made here: kulshekhar/ts-jest#1057 (comment) Fixes hyperledger-cacti#3254 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
5 tasks
petermetz
added
Keychain
Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Flaky-Test-Automation
Issues related to test stability (which is a long running issue that can never fully be solved)
Tests
Anything related to tests be that automatic or manual, integration or unit, etc.
labels
May 10, 2024
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
May 16, 2024
Found the solution and a long discussion about it here: kulshekhar/ts-jest#1057 TLDR: The Jest resolver needs a little extra information/tweak to the config so that it can correctly handle the .js imports. Specifically this comment provided the solution which I made here: kulshekhar/ts-jest#1057 (comment) Fixes hyperledger-cacti#3254 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
May 16, 2024
Found the solution and a long discussion about it here: kulshekhar/ts-jest#1057 TLDR: The Jest resolver needs a little extra information/tweak to the config so that it can correctly handle the .js imports. Specifically this comment provided the solution which I made here: kulshekhar/ts-jest#1057 (comment) Fixes hyperledger-cacti#3254 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this issue
May 16, 2024
Found the solution and a long discussion about it here: kulshekhar/ts-jest#1057 TLDR: The Jest resolver needs a little extra information/tweak to the config so that it can correctly handle the .js imports. Specifically this comment provided the solution which I made here: kulshekhar/ts-jest#1057 (comment) Fixes #3254 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
github-project-automation
bot
moved this from In review
to Done
in Cacti_Scrum_Project_v2_Release
May 16, 2024
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this issue
Jul 30, 2024
Found the solution and a long discussion about it here: kulshekhar/ts-jest#1057 TLDR: The Jest resolver needs a little extra information/tweak to the config so that it can correctly handle the .js imports. Specifically this comment provided the solution which I made here: kulshekhar/ts-jest#1057 (comment) Fixes hyperledger-cacti#3254 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Flaky-Test-Automation
Issues related to test stability (which is a long running issue that can never fully be solved)
Keychain
Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Tests
Anything related to tests be that automatic or manual, integration or unit, etc.
Description
Reproduce by executing this on
main
:yarn jest packages/cactus-plugin-keychain-memory/src/test/typescript/integration/api-surface.test.ts
and then watch it fail as such:
Acceptance Criteria
.js
extension files OR fix the Jest config whichever turns out to be the solution that doesn't add more tech. debt.The text was updated successfully, but these errors were encountered: