Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(aries): refactor jest test negative test cases #3473

Closed
ashnashahgrover opened this issue Aug 12, 2024 · 0 comments · Fixed by #3474
Closed

test(aries): refactor jest test negative test cases #3473

ashnashahgrover opened this issue Aug 12, 2024 · 0 comments · Fixed by #3474
Assignees
@ashnashahgrover
Labels
enhancement New feature or request good-first-issue-100-introductory P3 Priority 3: Medium

Comments

@ashnashahgrover
Copy link
Contributor

Refactor all the negative test case exception assertions for cactus-plugin-ledger-connector-aries so that they do not use try-catch blocks but instead declare the requirements through Jest's (and jest-extended's) own API.

The parent issue with a much more detailed explanation of what's needed and code examples on how to do it:
Parent Issue: https://github.com/hyperledger/cacti/issues/3455

Acceptance Criteria
Test passes the same as before
Negative test case assertions have been migrated the way it is explained in the parent issue.
@ashnashahgrover ashnashahgrover added the enhancement New feature or request label Aug 12, 2024
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 12, 2024
@ashnashahgrover
test(aries): refactor jest test negative test cases
2ccd806 
Primary Changes
----------------
1. Refactored all the negative test case exception assertions for
cactus-plugin-ledger-connector-aries. Removed try-catch blocks,
replaced with declarations through jest-extended's own API.

Fixes hyperledger-cacti#3473

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@ashnashahgrover ashnashahgrover mentioned this issue Aug 12, 2024
Merged
5 tasks
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 12, 2024
@ashnashahgrover
test(aries): refactor jest test negative test cases
f500d5c 
Primary Changes
----------------
1. Refactored all the negative test case exception assertions for
cactus-plugin-ledger-connector-aries. Removed try-catch blocks,
replaced with declarations through jest-extended's own API.

Fixes hyperledger-cacti#3473

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 16, 2024
@ashnashahgrover
test(aries): refactor jest test negative test cases
474652c 
Primary Changes
----------------
1. Refactored all the negative test case exception assertions for
cactus-plugin-ledger-connector-aries. Removed try-catch blocks,
replaced with declarations through jest-extended's own API.

Fixes hyperledger-cacti#3473

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
outSH pushed a commit to ashnashahgrover/cacti that referenced this issue Aug 22, 2024
@ashnashahgrover @outSH
test(aries): refactor jest test negative test cases
3225d66 
Primary Changes
----------------
1. Refactored all the negative test case exception assertions for
cactus-plugin-ledger-connector-aries. Removed try-catch blocks,
replaced with declarations through jest-extended's own API.

Fixes hyperledger-cacti#3473

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@outSH outSH closed this as completed in bf35762 Aug 22, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Cacti_Scrum_Project_v2_Release Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashnashahgrover ashnashahgrover

Labels
enhancement New feature or request good-first-issue-100-introductory P3 Priority 3: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(aries): refactor jest test negative test cases ashnashahgrover/cacti
2 participants
@ashnashahgrover @jagpreetsinghsasan