Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): upgrade setup-node@v4.0.3 checkout@v4.1.7 cache@v4.0.2 #3477

Closed
petermetz opened this issue Aug 12, 2024 · 0 comments · Fixed by #3478
Closed

ci(github): upgrade setup-node@v4.0.3 checkout@v4.1.7 cache@v4.0.2 #3477

petermetz opened this issue Aug 12, 2024 · 0 comments · Fixed by #3478
Assignees
@petermetz
Labels
Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Milestone
v2.0.0-rc.4

Comments

@petermetz
Copy link
Contributor

Description

We started getting warnings about deprecated versions of certain stock GitHub authored actions older versions like this:

cp-bungee-hermes The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@v3.6.0, actions/checkout@v3.5.2, actions/cache@v3.3.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The scope here is to upgrade the 3 mentioned actions to the latest current stable versions as described in the title.

Acceptance Criteria

  1. All the CI jobs that were passing before are still passing.
  2. Consistent upgrades: All jobs use the same versions.
@petermetz petermetz added the Tests Anything related to tests be that automatic or manual, integration or unit, etc. label Aug 12, 2024
@petermetz petermetz added this to the v2.0.0-rc.4 milestone Aug 12, 2024
@petermetz petermetz self-assigned this Aug 12, 2024
petermetz added a commit to petermetz/cacti that referenced this issue Aug 12, 2024
@petermetz
ci(github): upgrade setup-node@v4.0.3 checkout@v4.1.7 cache@v4.0.2
164ec1e 
1. Fixes the GitHub action linter warnings (the ones that show up on the
summary page of the action execution)
2. Adds another ignore line to the eslint ignore file that randomly popped up:
`weaver/core/identity-management/iin-agent/out/`

Fixes hyperledger-cacti#3477

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Aug 12, 2024
Merged
5 tasks
petermetz added a commit to petermetz/cacti that referenced this issue Aug 13, 2024
@petermetz
ci(github): upgrade setup-node@v4.0.3 checkout@v4.1.7 cache@v4.0.2
0eaea18 
1. Fixes the GitHub action linter warnings (the ones that show up on the
summary page of the action execution)
2. Adds another ignore line to the eslint ignore file that randomly popped up:
`weaver/core/identity-management/iin-agent/out/`

Fixes hyperledger-cacti#3477

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Aug 13, 2024
@petermetz
ci(github): upgrade setup-node@v4.0.3 checkout@v4.1.7 cache@v4.0.2
9ce9057 
1. Fixes the GitHub action linter warnings (the ones that show up on the
summary page of the action execution)
2. Adds another ignore line to the eslint ignore file that randomly popped up:
`weaver/core/identity-management/iin-agent/out/`

Fixes #3477

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
v2.0.0-rc.4
Development

Successfully merging a pull request may close this issue.

ci(github): upgrade setup-node@v4.0.3 checkout@v4.1.7 cache@v4.0.2 petermetz/cacti
1 participant
@petermetz