Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-fabric): contract deployment to 2.x ledgers #654

Closed
petermetz opened this issue Mar 10, 2021 · 0 comments · Fixed by #841
Closed

feat(connector-fabric): contract deployment to 2.x ledgers #654

petermetz opened this issue Mar 10, 2021 · 0 comments · Fixed by #841
Labels
enhancement New feature or request Fabric good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.

Comments

@petermetz
Copy link
Contributor

petermetz commented Mar 10, 2021

Is your feature request related to a problem? Please describe.

Currently the Fabric connector only supports deploying contracts to the 1.x ledgers.

Describe the solution you'd like

Need to be able to support 2.x ledgers as well.

Describe alternatives you've considered

None, I'm pretty sure we need this.

Additional context

This was left out of the original PR introducing contract deployment as a feature in order to save time for other features.

There's a work in progress branch here: https://github.com/petermetz/cactus/tree/feat-654

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo

@petermetz petermetz added enhancement New feature or request Fabric good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Mar 10, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
Primary change:
--------------

Add support for deploying contracts to Fabric 2.x ledgers
Languages supported (and covered by tests):
- golang
- javascript
- typescript

It is assumed that the server that is running the Fabric
ledger containers have the required dependencies to build
the contracts.
In the case of the tests this is provided by the Cactus
Fabric All-In-One container image which has NodeJS and Go
installed on it.

Secondary change(s):
-------------------

Breaking API change: renamed the contract deployment endpoint
that supports Fabric 1.4.x so that:
- the default implementation of it now assumes Fabric 2.x
- there is still a compatible version of the endpoint for 1.4.x

Fixes hyperledger-cacti#654

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
Primary change:
--------------

Add support for deploying contracts to Fabric 2.x ledgers
Languages supported (and covered by tests):
- golang
- javascript
- typescript

It is assumed that the server that is running the Fabric
ledger containers have the required dependencies to build
the contracts.
In the case of the tests this is provided by the Cactus
Fabric All-In-One container image which has NodeJS and Go
installed on it.

Secondary change(s):
-------------------

Breaking API change: renamed the contract deployment endpoint
that supports Fabric 1.4.x so that:
- the default implementation of it now assumes Fabric 2.x
- there is still a compatible version of the endpoint for 1.4.x

Fixes hyperledger-cacti#654

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 24, 2021
Primary change:
--------------

Add support for deploying contracts to Fabric 2.x ledgers
Languages supported (and covered by tests):
- golang
- javascript
- typescript

It is assumed that the server that is running the Fabric
ledger containers have the required dependencies to build
the contracts.
In the case of the tests this is provided by the Cactus
Fabric All-In-One container image which has NodeJS and Go
installed on it.

Secondary change(s):
-------------------

Breaking API change: renamed the contract deployment endpoint
that supports Fabric 1.4.x so that:
- the default implementation of it now assumes Fabric 2.x
- there is still a compatible version of the endpoint for 1.4.x

Fixes hyperledger-cacti#654

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 25, 2021
Primary change:
--------------

Add support for deploying contracts to Fabric 2.x ledgers
Languages supported (and covered by tests):
- golang
- javascript
- typescript

It is assumed that the server that is running the Fabric
ledger containers have the required dependencies to build
the contracts.
In the case of the tests this is provided by the Cactus
Fabric All-In-One container image which has NodeJS and Go
installed on it.

Secondary change(s):
-------------------

Breaking API change: renamed the contract deployment endpoint
that supports Fabric 1.4.x so that:
- the default implementation of it now assumes Fabric 2.x
- there is still a compatible version of the endpoint for 1.4.x

Fixes hyperledger-cacti#654

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 25, 2021
Primary change:
--------------

Add support for deploying contracts to Fabric 2.x ledgers
Languages supported (and covered by tests):
- golang
- javascript
- typescript

It is assumed that the server that is running the Fabric
ledger containers have the required dependencies to build
the contracts.
In the case of the tests this is provided by the Cactus
Fabric All-In-One container image which has NodeJS and Go
installed on it.

Secondary change(s):
-------------------

Breaking API change: renamed the contract deployment endpoint
that supports Fabric 1.4.x so that:
- the default implementation of it now assumes Fabric 2.x
- there is still a compatible version of the endpoint for 1.4.x

Fixes hyperledger-cacti#654

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Apr 27, 2021
Primary change:
--------------

Add support for deploying contracts to Fabric 2.x ledgers
Languages supported (and covered by tests):
- golang
- javascript
- typescript

It is assumed that the server that is running the Fabric
ledger containers have the required dependencies to build
the contracts.
In the case of the tests this is provided by the Cactus
Fabric All-In-One container image which has NodeJS and Go
installed on it.

Secondary change(s):
-------------------

Breaking API change: renamed the contract deployment endpoint
that supports Fabric 1.4.x so that:
- the default implementation of it now assumes Fabric 2.x
- there is still a compatible version of the endpoint for 1.4.x

Fixes #654

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fabric good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant