Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector-besu): fix hardcoded test port #767

Closed
petermetz opened this issue Apr 2, 2021 · 0 comments · Fixed by #768
Closed

test(connector-besu): fix hardcoded test port #767

petermetz opened this issue Apr 2, 2021 · 0 comments · Fixed by #768
Labels
Besu bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@petermetz
Copy link
Contributor

petermetz commented Apr 2, 2021 •
edited
Loading

https://github.com/hyperledger/cactus/blob/bfc9c19969267e1db861ced28f4859251446570d/packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/deploy-contract-from-json.test.ts#L93

Port needs to be 0 so that it doesn't accidentally collide with other tests that are running in parallel.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan
@petermetz petermetz added bug Something isn't working Besu dependencies Pull requests that update a dependency file labels Apr 2, 2021
@petermetz petermetz changed the title test(connector-besu): fix hardcoded test port that needs to be random test(connector-besu): fix hardcoded test port Apr 2, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Apr 2, 2021
@petermetz
test(connector-besu): fix hardcoded test port hyperledger-cacti#767
69a5102 
Fixes hyperledger-cacti#767

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Apr 2, 2021
Merged
petermetz added a commit that referenced this issue Apr 5, 2021
@petermetz
test(connector-besu): fix hardcoded test port #767
eaefbab 
Fixes #767

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Besu bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(connector-besu): fix hardcoded test port #767 petermetz/cacti
1 participant
@petermetz