Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validator,verifier): delete some minor duplicated documents #1001

Conversation

takeutak
Copy link
Contributor

@takeutak takeutak commented May 31, 2021

Resolve #1002

Signed-off-by: Takuma TAKEUCHI takeuchi.takuma@fujitsu.com

Signed-off-by: Takuma TAKEUCHI <takeuchi.takuma@fujitsu.com>
@takeutak takeutak requested a review from sfuji822 May 31, 2021 10:50
@takeutak takeutak changed the title fix(validator,verifier): delete some minor duplicated files fix(validator,verifier): delete some minor duplicated documents May 31, 2021
Copy link
Contributor

@sfuji822 sfuji822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@takeutak
Copy link
Contributor Author

takeutak commented Jun 8, 2021

@petermetz It is inefficient to apply CI check tool to pull request of minor change of document. I need to run the CI check tool every time a pull-request is merged. I am waiting for several hours for the CI check tool to complete its operation in order to merge this small pull-requests.

I think this situation will significantly impede the development efficiency in Cactus. I have written a solution in the issue below, could you consider it? #1014

@takeutak takeutak merged commit 9acb8ab into hyperledger-cacti:main Jun 8, 2021
@petermetz
Copy link
Contributor

@takeutak I agree completely and definitely understand the pain of not being able to merge documentation only pull requests in a timely manner. I have one for example that's been waiting for review for one thousand eight hundred and sixty-one hours. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(validator,verifier): delete some minor duplicated documents
3 participants