Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-api): add plugin object store interface definition #1032

Conversation

petermetz
Copy link
Contributor

This will be implemented by object store plugins so as to
have guarantee that at runtime the plugins can be used the
way the caller expects them to.

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

This will be implemented by object store plugins so as to
have guarantee that at runtime the plugins can be used the
way the caller expects them to.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz added enhancement New feature or request Core_API Changes related to the Core API Package labels Jun 14, 2021
@petermetz petermetz added this to the v0.7.0 milestone Jun 14, 2021
@petermetz petermetz self-assigned this Jun 14, 2021
@takeutak
Copy link
Contributor

takeutak commented Jun 16, 2021

@petermetz Just to confirm, what is the intent behind the functionality around this IPFS plugin? (What types of data are you going to put on distributed storage?) **related with #1007, #1033

@petermetz
Copy link
Contributor Author

@petermetz Just to confirm, what is the intent behind the functionality around this IPFS plugin? (What types of data are you going to put on distributed storage?) **related with #1007, #1033

@takeutak Nothing planned at the moment. It will be up to the BLP authors to use it as they see fit, store the kind of data they want as part of their business logic.

@takeutak
Copy link
Contributor

@petermetz Thanks to answer! Is this IPFS function required by releasing V1-RC as the roadmap #716 ? If this is not so, I would like to arrange the core functions on the roadmap on #716 and I'm sure that we should concentrate on the development of core functions. (related with #1007, #1033)

@petermetz
Copy link
Contributor Author

@takeutak Cheers! It's not needed for 1.0-RC, but it is needed for something else internally.

@takeutak
Copy link
Contributor

@petermetz Thanks for your commit.
As I discussed on the previous, IPFS plugin seems to be suitable to be moved to an extension feature (= optional feature).
The features about ObjectRequest (GetObjectRequestV1, HasObjectRequestV1, etc.) seem to be ones for IPFS plugins. Could you mind if you move these features to some extension?

@petermetz
Copy link
Contributor Author

@petermetz Thanks for your commit.
As I discussed on the previous, IPFS plugin seems to be suitable to be moved to an extension feature (= optional feature).
The features about ObjectRequest (GetObjectRequestV1, HasObjectRequestV1, etc.) seem to be ones for IPFS plugins. Could you mind if you move these features to some extension?

@takeutak I would need to create a brand new package for it. Is that acceptable?

@petermetz petermetz requested a review from kikoncuo July 7, 2021 15:54
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #1032 (398c2de) into main (e54f2f9) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   73.15%   73.14%   -0.02%     
==========================================
  Files         245      246       +1     
  Lines        8613     8617       +4     
  Branches      995      996       +1     
==========================================
+ Hits         6301     6303       +2     
- Misses       1781     1783       +2     
  Partials      531      531              
Impacted Files Coverage Δ
...pescript/generated/openapi/typescript-axios/api.ts 100.00% <ø> (ø)
...pt/plugin/object-store/is-i-plugin-object-store.ts 33.33% <33.33%> (ø)
.../cactus-core-api/src/main/typescript/public-api.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54f2f9...398c2de. Read the comment docs.

@petermetz petermetz modified the milestones: v0.7.0, v0.6.0 Jul 11, 2021
@petermetz petermetz merged commit 4bf8038 into hyperledger-cacti:main Jul 11, 2021
@petermetz petermetz deleted the feat-core-api-object-store-plugin-interface branch July 11, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core_API Changes related to the Core API Package enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants