-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-api): add plugin object store interface definition #1032
feat(core-api): add plugin object store interface definition #1032
Conversation
This will be implemented by object store plugins so as to have guarantee that at runtime the plugins can be used the way the caller expects them to. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz Just to confirm, what is the intent behind the functionality around this IPFS plugin? (What types of data are you going to put on distributed storage?) **related with #1007, #1033 |
@takeutak Nothing planned at the moment. It will be up to the BLP authors to use it as they see fit, store the kind of data they want as part of their business logic. |
@petermetz Thanks to answer! Is this IPFS function required by releasing V1-RC as the roadmap #716 ? If this is not so, I would like to arrange the core functions on the roadmap on #716 and I'm sure that we should concentrate on the development of core functions. (related with #1007, #1033) |
@takeutak Cheers! It's not needed for 1.0-RC, but it is needed for something else internally. |
@petermetz Thanks for your commit. |
@takeutak I would need to create a brand new package for it. Is that acceptable? |
Codecov Report
@@ Coverage Diff @@
## main #1032 +/- ##
==========================================
- Coverage 73.15% 73.14% -0.02%
==========================================
Files 245 246 +1
Lines 8613 8617 +4
Branches 995 996 +1
==========================================
+ Hits 6301 6303 +2
- Misses 1781 1783 +2
Partials 531 531
Continue to review full report at Codecov.
|
This will be implemented by object store plugins so as to
have guarantee that at runtime the plugins can be used the
way the caller expects them to.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com