test(connector-fabric): fix v1.4.8 golang chaincode test #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinned all the hello world chaincode's dependencies to exact versions that are known to have worked in the past for builds. We needed this because the 1.13 go version of the Fabric CLI container could no longer build (tidy+vendor) the dependencies that were built with the newer versions of go such as 1.16 and 1.17. More info about the root cause can be read here: golang/go#40067 By locking the dependencies versions to older ones we we ensured that the older go installation of the Fabric CLI container does not fail. The known-to-be-working dependency versions are coming from packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/fixtures/go/hello-world-contract-fabric-v14/hello-world-contract-go-mod.ts Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added
bug
takeutak
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned all the hello world chaincode's dependencies to exact versions
that are known to have worked in the past for builds. We needed this
because the 1.13 go version of the Fabric CLI container could no
longer build (tidy+vendor) the dependencies that were built with the
newer versions of go such as 1.16 and 1.17.
More info about the root cause can be read here:
golang/go#40067
By locking the dependencies versions to older ones we we ensured that
the older go installation of the Fabric CLI container does not fail.
The known-to-be-working dependency versions are coming from
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/fixtures/go/hello-world-contract-fabric-v14/hello-world-contract-go-mod.ts
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com