feat(connector-fabric): endorsing peers request arg #1122 #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
+ Coverage 73.14% 73.30% +0.16%
==========================================
Files 246 248 +2
Lines 8617 8782 +165
Branches 996 1025 +29
==========================================
+ Hits 6303 6438 +135
- Misses 1783 1796 +13
- Partials 531 548 +17
Continue to review full report at Codecov.
|
takeutak
approved these changes
Jul 15, 2021
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
petermetz
force-pushed
the
feat-1122
branch
2 times, most recently
from
7c950b0 to
2b97679
Compare
…#1122 Makes it possible to set the endorsing peers on a transaction when submitted through the Fabric connector. For example these values can be passed in to the new parameter and it will set the endorsers up accordingly prior to submitting the transaction to the ledger: - org1.example.com - Org1MSP - org2.example.com - Org2MSP (You only need either the org domain or the msp ID, no need to specify both of them for it to work). For a working example, see this test case: packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/ integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts Depends on hyperledger-cacti#1123 Depends on hyperledger-cacti#1130 Fixes hyperledger-cacti#1122 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.
For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).
For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts
Depends on #1123
Depends on #1130
Fixes #1122
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com