Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use yarn 1.19.0 instead of 1.22.10 #1165

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

petermetz
Copy link
Contributor

Needed to downgrade because of a bug in 1.22.10 where it was
unable to install dependencies into workspaces individually.

See details here: yarnpkg/yarn#8405

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Needed to downgrade because of a bug in 1.22.10 where it was
unable to install dependencies into workspaces individually.

See details here: yarnpkg/yarn#8405

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz added bug Something isn't working dependencies Pull requests that update a dependency file labels Jul 23, 2021
@petermetz petermetz added this to the v0.7.0 milestone Jul 23, 2021
@petermetz petermetz requested a review from takeutak July 23, 2021 01:05
@petermetz petermetz self-assigned this Jul 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #1165 (75a363a) into main (1419b2c) will not change coverage.
The diff coverage is n/a.

❗ Current head 75a363a differs from pull request most recent head d559008. Consider uploading reports for the commit d559008 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   72.49%   72.49%           
=======================================
  Files         261      261           
  Lines        9172     9172           
  Branches     1080     1080           
=======================================
  Hits         6649     6649           
  Misses       1953     1953           
  Partials      570      570           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1419b2c...d559008. Read the comment docs.

Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 9ca7f6e into hyperledger-cacti:main Jul 28, 2021
@petermetz petermetz deleted the build-yarn-v1-19-0 branch July 28, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants