Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd-api-server): add missing deps remove unused ones #1226 #1228

Merged
merged 2 commits into from
Aug 18, 2021
Merged

fix(cmd-api-server): add missing deps remove unused ones #1226 #1228

merged 2 commits into from
Aug 18, 2021

Conversation

petermetz
Copy link
Contributor

Fixes #1226

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

@petermetz
fix(cmd-api-server): add missing deps remove unused ones hyperledger-…
7df0245 
…cacti#1226

Fixes hyperledger-cacti#1226

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz added bug Something isn't working API_Server dependencies Pull requests that update a dependency file labels Aug 16, 2021
@petermetz petermetz added this to the v0.8.0 milestone Aug 16, 2021
@petermetz petermetz self-assigned this Aug 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021 •
edited
Loading

Codecov Report

Merging #1228 (09b5f59) into main (710ab76) will not change coverage.
The diff coverage is n/a.

❗ Current head 09b5f59 differs from pull request most recent head 918b61f. Consider uploading reports for the commit 918b61f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1228   +/-   ##
=======================================
  Coverage   71.95%   71.95%           
=======================================
  Files         270      270           
  Lines        9438     9438           
  Branches     1112     1112           
=======================================
  Hits         6791     6791           
  Misses       2075     2075           
  Partials      572      572

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 710ab76...918b61f. Read the comment docs.

jonathan-m-hamilton
jonathan-m-hamilton approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 17, 2021
@petermetz petermetz merged commit b348e42 into hyperledger-cacti:main Aug 18, 2021
@petermetz petermetz deleted the fix-1226 branch August 18, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takeutak takeutak takeutak approved these changes

@jonathan-m-hamilton jonathan-m-hamilton jonathan-m-hamilton approved these changes

Assignees

@petermetz petermetz

Labels
API_Server bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

fix(cmd-api-server): add missing deps remove unused ones
4 participants
@petermetz @codecov-commenter @jonathan-m-hamilton @takeutak