Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): remove no longer working scripts from package.json #1273

Merged

Conversation

m-courtin
Copy link
Contributor

Closes: #1271
Signed-off-by: Michael Courtin michael.courtin@accenture.com

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz requested review from takeutak and removed request for jonathan-m-hamilton August 25, 2021 14:58
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #1273 (7bd6187) into main (bd3fe40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1273   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files         278      278           
  Lines       10019    10019           
  Branches     1242     1242           
=======================================
  Hits         7197     7197           
  Misses       2159     2159           
  Partials      663      663           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd3fe40...7bd6187. Read the comment docs.

Closes: hyperledger-cacti#1271
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
@m-courtin m-courtin force-pushed the fix-1271-remove-deprecated-scripts branch from fe96d10 to 9767e09 Compare August 26, 2021 14:53
@petermetz petermetz merged commit fcf26ed into hyperledger-cacti:main Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(package.json): remove deprecated and no longer working build-dev scripts
4 participants