fix: openapi-validation test for quorum plugin #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenaizaguirre
force-pushed
the
openapi-validation-quorum
branch
from
b548765 to
f2b6d8f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
+ Coverage 67.83% 67.95% +0.11%
==========================================
Files 301 301
Lines 10948 10948
Branches 1347 1347
==========================================
+ Hits 7427 7440 +13
+ Misses 2832 2817 -15
- Partials 689 691 +2
Continue to review full report at Codecov.
|
elenaizaguirre
commented
Sep 1, 2021
packages/cactus-plugin-ledger-connector-quorum/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Sep 1, 2021
There was a problem hiding this comment.
@elenaizaguirre Same requests/questions here as in the other OpenAPI validation PR
elenaizaguirre
force-pushed
the
openapi-validation-quorum
branch
from
f2b6d8f to
0ecadc3
Compare
Includes tests for endpoints deployContractSolBytecodeV1, invokeContractV1 and runTransactionV1, each of them with test cases: - Right request - Request including an invalid parameter - Request without a required parameter Closes hyperledger-cacti#1286 Relationed with hyperledger-cacti#847 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
force-pushed
the
openapi-validation-quorum
branch
from
0ecadc3 to
ea61f3e
Compare
elenaizaguirre
changed the title
takeutak
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes tests for endpoints deployContractSolBytecodeV1,
invokeContractV1 and runTransactionV1, each of them
with test cases:
Closes: #1286
Relationed with #847
Signed-off-by: Elena Izaguirre e.izaguirre.equiza@accenture.com