fix: openapi-validation test for consortium-manual plugin #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenaizaguirre
force-pushed
the
openapi-validation-consortium-manual
branch
from
efcfb03 to
d47e244
Compare
Includes tests for endpoints getConsortiumJwsV1 and getNodeJwsV1, each one of them with test cases: - Right request - Sending an invalid parameter closes hyperledger-cacti#1297 relationed with hyperledger-cacti#847 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
force-pushed
the
openapi-validation-consortium-manual
branch
from
d47e244 to
fa23aca
Compare
elenaizaguirre
changed the title
petermetz
requested review from
jonathan-m-hamilton and
petermetz
as code owners
petermetz
requested review from
takeutak
and removed request for
jonathan-m-hamilton
petermetz
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
LGTM
@elenaizaguirre The CI is failing due to docker rate limits [1], I have an idea on how to fix it but it will take a minute to implement so please hang tight in the meantime.
[1]:
'toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit\r\n'
takeutak
approved these changes
Sep 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #1298 +/- ##
=======================================
Coverage 68.63% 68.63%
=======================================
Files 301 301
Lines 10948 10948
Branches 1347 1347
=======================================
Hits 7514 7514
Misses 2733 2733
Partials 701 701 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes tests for endpoints getConsortiumJwsV1 and
getNodeJwsV1, each one of them with test cases:
Closes: #1297
Relationed with #847
Signed-off-by: Elena Izaguirre e.izaguirre.equiza@accenture.com