fix: openapi validation test for keychain-vault plugin #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
approved these changes
Sep 14, 2021
petermetz
requested review from
takeutak
and removed request for
jonathan-m-hamilton
takeutak
approved these changes
Sep 15, 2021
Includes tests for endpoints setKeychainEntryV1, getKeychainEntryV1, deleteKeychainEntryV1 and hasKeychainEntryV1, each of them, when appropiate, with test cases: - Right request - Request including an invalid parameter - Request without a required parameter Closes hyperledger-cacti#1329 Relationed with hyperledger-cacti#847 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
force-pushed
the
openapi-keychain-vault
branch
from
a6ff1ab to
4735ceb
Compare
Codecov Report
@@ Coverage Diff @@
## main #1330 +/- ##
=======================================
Coverage 68.63% 68.63%
=======================================
Files 301 301
Lines 10948 10948
Branches 1347 1347
=======================================
Hits 7514 7514
Misses 2733 2733
Partials 701 701
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes tests for endpoints setKeychainEntryV1,
getKeychainEntryV1, deleteKeychainEntryV1 and
hasKeychainEntryV1, each of them, when appropiate,
with test cases:
Closes #1329
Relationed with #847
Signed-off-by: Elena Izaguirre e.izaguirre.equiza@accenture.com