Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): skip check when only documentation files #1014 #1336

Merged
merged 3 commits into from
Sep 21, 2021
Merged

feat(ci): skip check when only documentation files #1014 #1336

merged 3 commits into from
Sep 21, 2021

Conversation

AzaharaC
Copy link
Contributor

Resolve #1014

@AzaharaC AzaharaC self-assigned this Sep 15, 2021
@AzaharaC AzaharaC force-pushed the feat/issue-1014 branch 2 times, most recently from 04d3e57 to 529bddf Compare September 15, 2021 09:05
@AzaharaC
feat(ci): skip check when only documentation files hyperledger-cacti#…
529bddf 
…1014

Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
@AzaharaC AzaharaC marked this pull request as ready for review September 15, 2021 14:51
@AzaharaC AzaharaC requested a review from takeutak September 15, 2021 14:51
@takeutak
Copy link
Contributor

@AzaharaC Thanks for resolving my issue!

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #1336 (d70abd3) into main (8012d05) will not change coverage.
The diff coverage is n/a.

❗ Current head d70abd3 differs from pull request most recent head 8ae2c6e. Consider uploading reports for the commit 8ae2c6e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1336   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files         301      301           
  Lines       10949    10949           
  Branches     1348     1348           
=======================================
  Hits         7515     7515           
  Misses       2733     2733           
  Partials      701      701

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8012d05...8ae2c6e. Read the comment docs.

petermetz
petermetz approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 8937576 into hyperledger-cacti:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takeutak takeutak takeutak approved these changes

@petermetz petermetz petermetz approved these changes

@jonathan-m-hamilton jonathan-m-hamilton Awaiting requested review from jonathan-m-hamilton

Assignees

@AzaharaC AzaharaC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature(ci): add to the option to skip CI checking
4 participants
@AzaharaC @takeutak @codecov-commenter @petermetz