feat: allows for constructor args in quorum contract deploy #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis-payne
requested review from
jonathan-m-hamilton and
petermetz
as code owners
takeutak
approved these changes
Oct 7, 2021
Codecov Report
@@ Coverage Diff @@
## main #1447 +/- ##
=======================================
Coverage 71.82% 71.82%
=======================================
Files 317 317
Lines 11564 11568 +4
Branches 1415 1416 +1
=======================================
+ Hits 8306 8309 +3
Misses 2477 2477
- Partials 781 782 +1
Continue to review full report at Codecov.
|
petermetz
requested changes
Oct 7, 2021
.../cactus-plugin-ledger-connector-quorum/src/main/typescript/plugin-ledger-connector-quorum.ts
Outdated
Show resolved
Hide resolved
.../cactus-plugin-ledger-connector-quorum/src/main/typescript/plugin-ledger-connector-quorum.ts
Outdated
Show resolved
Hide resolved
travis-payne
force-pushed
the
deploy-contract-args
branch
2 times, most recently
from
8cfcd60 to
80261f8
Compare
petermetz
requested changes
Oct 15, 2021
There was a problem hiding this comment.
@travis-payne Please rebase+squash and then we are good to go!
petermetz
requested changes
Oct 21, 2021
There was a problem hiding this comment.
@travis-payne Please rebase+squash into a single commit and then we are good to go!
Closes: hyperledger-cacti#962 Signed-off-by: Travis Payne <travis.payne@accenture.com>
travis-payne
force-pushed
the
deploy-contract-args
branch
from
a11f5f5 to
4ceeb64
Compare
petermetz
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #962
Signed-off-by: Travis Payne travis.payne@accenture.com