fix(plugin-ledger-connectors): fixes 1445 and implementing correct interface types #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-courtin
requested review from
jonathan-m-hamilton and
petermetz
as code owners
m-courtin
force-pushed
the
fix-1445-wrong-interface-types
branch
from
fb4ade3 to
94816e5
Compare
takeutak
approved these changes
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #1457 +/- ##
=======================================
Coverage 68.35% 68.36%
=======================================
Files 333 333
Lines 12524 12526 +2
Branches 1507 1507
=======================================
+ Hits 8561 8563 +2
Misses 3152 3152
Partials 811 811
Continue to review full report at Codecov.
|
petermetz
reviewed
Oct 15, 2021
...ages/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts
Outdated
Show resolved
Hide resolved
m-courtin
force-pushed
the
fix-1445-wrong-interface-types
branch
5 times, most recently
from
eefa228 to
9ae7ca1
Compare
m-courtin
force-pushed
the
fix-1445-wrong-interface-types
branch
2 times, most recently
from
c91172d to
4cb6d32
Compare
m-courtin
force-pushed
the
fix-1445-wrong-interface-types
branch
2 times, most recently
from
e1bb7a4 to
21e5598
Compare
For all the connector class definitions the implementation are fixed to follow their interface definition and to match in consistent way for all the connectors Closes: hyperledger-cacti#1445 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
force-pushed
the
fix-1445-wrong-interface-types
branch
from
21e5598 to
6aa1fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all the connector class definitions the implementation are fixed to
follow their interface definition and to match in consistent way for all
the connectors
Closes: #1445
Signed-off-by: Michael Courtin michael.courtin@accenture.com