Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip flaky fabric 2.2.x deploy cc from JS test #1472

Conversation

petermetz
Copy link
Contributor

This is related to #1471 (does not fix it though). In order to enable
faster CI/PR turnaround times we are aggressively eliminating (skipping)
flaky tests and creating issues in the backlog for fixing them later on.

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

This is related to hyperledger-cacti#1471 (does not fix it though). In order to enable
faster CI/PR turnaround times we are aggressively eliminating (skipping)
flaky tests and creating issues in the backlog for fixing them later on.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz self-assigned this Oct 21, 2021
@petermetz petermetz added Developer_Experience Fabric Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. labels Oct 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #1472 (c4dddad) into main (db0941e) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
- Coverage   71.86%   71.82%   -0.05%     
==========================================
  Files         317      317              
  Lines       11564    11564              
  Branches     1415     1415              
==========================================
- Hits         8311     8306       -5     
- Misses       2472     2477       +5     
  Partials      781      781              
Impacted Files Coverage Δ
.../main/typescript/plugin-ledger-connector-fabric.ts 64.30% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0941e...c4dddad. Read the comment docs.

Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 4e6f1c3 into hyperledger-cacti:main Oct 22, 2021
@petermetz petermetz deleted the test-skip-fabric-v2-2-x-deploy-cc-from-javascript branch October 22, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer_Experience Fabric Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants