fix(connector-quorum): transaction with different credentials #1098

[AzaharaC]

Resolves #1098

[petermetz]

@AzaharaC LGTM, just have a small nit: Please include a logging statement on the debug level within the if condition that checks for a falsy gas value.
The logging statement should make it clear that gas was not explicitly specified and therefore we'll be using the estimate from web3 and also include what the estimated value came out to be.

[AzaharaC]

@AzaharaC LGTM, just have a small nit: Please include a logging statement on the debug level within the if condition that checks for a falsy gas value. The logging statement should make it clear that gas was not explicitly specified and therefore we'll be using the estimate from web3 and also include what the estimated value came out to be.

I updated the PR to include the logging statement

[codecov-commenter]

Codecov Report

Merging #1488 (6e5babc) into main (9022064) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 6e5babc differs from pull request most recent head fa238de. Consider uploading reports for the commit fa238de to get more accurate results

@@            Coverage Diff             @@
##             main    #1488      +/-   ##
==========================================
- Coverage   69.80%   69.78%   -0.03%     
==========================================
  Files         336      336              
  Lines       12622    12626       +4     
  Branches     1512     1513       +1     
==========================================
  Hits         8811     8811              
- Misses       2989     2992       +3     
- Partials      822      823       +1     

Impacted Files	Coverage Δ
.../main/typescript/plugin-ledger-connector-quorum.ts	74.44% <0.00%> (-1.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9022064...fa238de. Read the comment docs.

[petermetz]

@AzaharaC Thank you for adding the logging statements! LGTM