fix: openapi validation for keychain-aws-sm plugin #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenaizaguirre
force-pushed
the
openapi-validation-keychain-aws-sm
branch
2 times, most recently
from
5e4921f to
5d2c052
Compare
Codecov Report
@@ Coverage Diff @@
## main #1514 +/- ##
==========================================
+ Coverage 70.03% 70.04% +0.01%
==========================================
Files 368 368
Lines 14108 14108
Branches 1701 1701
==========================================
+ Hits 9880 9882 +2
+ Misses 3299 3298 -1
+ Partials 929 928 -1
Continue to review full report at Codecov.
|
elenaizaguirre
requested review from
jonathan-m-hamilton and
petermetz
as code owners
takeutak
approved these changes
Nov 8, 2021
Includes tests for endpoints setKeychainEntry, getKeychainEntryV1, hasKeychainEntryV1 and deleteKeychainEntryV1, each of them with test cases: - Right request - Request including an invalid parameter - Request without a required parameter Relationed with hyperledger-cacti#847 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
force-pushed
the
openapi-validation-keychain-aws-sm
branch
from
5d2c052 to
59f06d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes tests for endpoints setKeychainEntry, getKeychainEntryV1,
hasKeychainEntryV1 and deleteKeychainEntryV1, each of them with
test cases:
Relationed with #847
Signed-off-by: Elena Izaguirre e.izaguirre.equiza@accenture.com