feat(connector-xdai): remove hard dependency on keychain #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenaizaguirre
requested review from
jonathan-m-hamilton and
petermetz
as code owners
elenaizaguirre
requested review from
takeutak
and removed request for
jonathan-m-hamilton
elenaizaguirre
force-pushed
the
remove-dependency-keychain-xdai
branch
from
b18690f to
8948689
Compare
elenaizaguirre
force-pushed
the
remove-dependency-keychain-xdai
branch
from
8948689 to
ec57c36
Compare
elenaizaguirre
changed the title
elenaizaguirre
force-pushed
the
remove-dependency-keychain-xdai
branch
2 times, most recently
from
53f4d4d to
5d64c48
Compare
takeutak
approved these changes
Dec 2, 2021
elenaizaguirre
force-pushed
the
remove-dependency-keychain-xdai
branch
from
5d64c48 to
0891745
Compare
petermetz
reviewed
Dec 6, 2021
packages/cactus-plugin-ledger-connector-xdai/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
petermetz
added
the
Xdai
elenaizaguirre
force-pushed
the
remove-dependency-keychain-xdai
branch
from
0891745 to
2606261
Compare
petermetz
requested changes
Dec 14, 2021
There was a problem hiding this comment.
@elenaizaguirre Sorry for the slow communication on this one. Please eliminate the any types as we discussed in today's call and then the change should be good to go.
elenaizaguirre
force-pushed
the
remove-dependency-keychain-xdai
branch
from
2606261 to
f911b9a
Compare
@petermetz Done! Thanks for your help |
petermetz
requested changes
Dec 14, 2021
...ages/cactus-plugin-ledger-connector-xdai/src/main/typescript/plugin-ledger-connector-xdai.ts
Outdated
Show resolved
Hide resolved
Resolves hyperledger-cacti#1162 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
force-pushed
the
remove-dependency-keychain-xdai
branch
from
f911b9a to
22fbb67
Compare
petermetz
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
@petermetz Sure, sorry for the confusion
@elenaizaguirre No worries, thank you again, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1162
Signed-off-by: Elena Izaguirre e.izaguirre.equiza@accenture.com