Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-odap-hermes): remove extraneous dependencies #1643

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

petermetz
Copy link
Contributor

  1. Removed a lot of extraneous dependencies and
  2. Changed the license to Apache-2.0 from ISC

Fixes #1641

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

@petermetz petermetz requested review from jagpreetsinghsasan and takeutak and removed request for jonathan-m-hamilton December 8, 2021 19:05
@petermetz petermetz self-assigned this Dec 8, 2021
@petermetz petermetz added dependencies Pull requests that update a dependency file Developer_Experience labels Dec 8, 2021
@petermetz
Copy link
Contributor Author

@jscode017 @RafaelAPB Please verify that this change is okay with you as well, specifically the part about the incorrect license fix.

1. Removed a lot of extraneous dependencies and
2. Changed the license to Apache-2.0 from ISC

Fixes hyperledger-cacti#1641

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the petermetz/issue1641 branch from 5595a4f to 636dfd9 Compare December 8, 2021 19:21
@RafaelAPB
Copy link
Contributor

I am good with this too, @petermetz. Thanks.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 87af023 into hyperledger-cacti:main Dec 17, 2021
@petermetz petermetz deleted the petermetz/issue1641 branch December 17, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Developer_Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(plugin-odap-hermes): remove extraneous dependencies
5 participants