feat(connector-corda): read privateKey from filesystem

[elenaizaguirre]

Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aio container

Relationed with #789

Signed-off-by: Elena Izaguirre e.izaguirre.equiza@accenture.com

[petermetz]

@elenaizaguirre

Would something like this work (need to substitute the container ID variable)?

export CORDA_AIO_IMAGE_KEY=$(docker exec $CONTAINER_ID cat /etc/hyperledger/cactus/corda-aio-image.key)

then in the compose file you just use the environment variable as usual:

https://docs.docker.com/compose/environment-variables/#pass-environment-variables-to-containers

https://docs.docker.com/compose/environment-variables/#substitute-environment-variables-in-compose-files

And finally what I wanted to double check is the specific reason for using docker compose. Is it to simplify manual testing or are you somehow embedding the docker compose parts into a test case?

[elenaizaguirre]

@elenaizaguirre

Would something like this work (need to substitute the container ID variable)?

export CORDA_AIO_IMAGE_KEY=$(docker exec $CONTAINER_ID cat /etc/hyperledger/cactus/corda-aio-image.key)

then in the compose file you just use the environment variable as usual:

https://docs.docker.com/compose/environment-variables/#pass-environment-variables-to-containers

https://docs.docker.com/compose/environment-variables/#substitute-environment-variables-in-compose-files

And finally what I wanted to double check is the specific reason for using docker compose. Is it to simplify manual testing or are you somehow embedding the docker compose parts into a test case?

@petermetz

I am using docker compose because I think it improves the user experience by deploying all containers with a single command, but I'm having a lot of problems because of it.

If you want to see what I am doing it is available in this branch.

Now I am not sure how to deal with this issue, I think there are three ways to do it:

1. Forget docker compose and do it with independent containers

2. Create the keys from the host and also send them to corda-aio as environment variables (we would have to modify the image so I don't think this is the best option).

3. Merge this PR, I now have the key located inside the second container so it would not be a problem. I used your command to export the key to a host file and then pass it as a secret to the second container (it is not possible to do it in this case with environment variables because they are evaluated before starting the first container).

[petermetz]

@elenaizaguirre Got it, thank you for explaining. I am definitely in favor of merging this PR so that option 3) becomes feasible ASAP and we can think about the rest of them later as well. Thank you for addressing my change requests.

[izuru0]

LGTM