fix(security): address CVE-2021-23358

[zondervancalvez]

fixes: #1775

[zondervancalvez]

review-requested: @petermetz

[petermetz]

@zondervancalvez There's no diff though. Did a rebase or merge gone wrong or was this fixed by somebody else concurrently in the meantime and that got merged first with the exact same diff?

[petermetz]

@zondervancalvez There's no diff though. Did a rebase or merge gone wrong or was this fixed by somebody else concurrently in the meantime and that got merged first with the exact same diff?

+1

[zondervancalvez]

This is 2 part changes:

1. All changes are migration from web3-eea to web3js-quorum.
2. This is also related to fix(security): address CVE-2021-23337 #1820

[petermetz]

@zondervancalvez Question: Where did you get the index.d.ts file from?

[zondervancalvez]

@zondervancalvez Question: Where did you get the index.d.ts file from?

Here:
https://github.com/ConsenSys/web3js-quorum/blob/master/src/typescript/index.d.ts

[petermetz]

@zondervancalvez Please make the tests pass, right now the CI is failing with this:

Error: Cannot find module 'web3-eea'
Require stack:
- /home/runner/work/cactus/cactus/packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-cactus.test.ts
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:889:15)
    at Function.Module._load (internal/modules/cjs/loader.js:745:27)
    at Module.require (internal/modules/cjs/loader.js:961:19)
    at require (internal/modules/cjs/helpers.js:92:18)
    at Object.<anonymous> (/home/runner/work/cactus/cactus/packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-cactus.test.ts:2:966)
    at Module._compile (internal/modules/cjs/loader.js:1072:14)
    at Module.replacementCompile (/home/runner/work/cactus/cactus/node_modules/append-transform/index.js:60:13)
    at Module.m._compile (/home/runner/work/cactus/cactus/node_modules/ts-node/src/index.ts:1311:23)
    at module.exports (/home/runner/work/cactus/cactus/node_modules/default-require-extensions/js.js:7:9)
    at /home/runner/work/cactus/cactus/node_modules/append-transform/index.js:64:4
    at require.extensions.<computed> (/home/runner/work/cactus/cactus/node_modules/ts-node/src/index.ts:1314:12)
    at Object.<anonymous> (/home/runner/work/cactus/cactus/node_modules/append-transform/index.js:64:4)
    at Module.load (internal/modules/cjs/loader.js:937:32)
    at Function.Module._load (internal/modules/cjs/loader.js:778:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/cactus/cactus/packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-cactus.test.ts'
  ]
}
# Subtest: ./packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-cactus.test.ts
    1..0 # no tests found
not ok 54 - ./packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-cactus.test.ts # time=11406.73ms

[petermetz]

@zondervancalvez Please also resolve the merge conflicts!

[petermetz]

@zondervancalvez LGTM, thank you!

[petermetz]

@zondervancalvez Unless you made some updates to the diff/code that should be explicitly re-checked by the reviewers (because it's different from what was approved), there's usually no need to re-request review from those who already approved (in this case Takuma)