Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-corda): support corda 5 #1860

Closed
wants to merge 1 commit into from

Conversation

AzaharaC
Copy link
Contributor

Resolve #1480

Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
@petermetz petermetz requested review from izuru0 and takeutak and removed request for jonathan-m-hamilton February 22, 2022 00:08
@petermetz petermetz added Corda P1 Priority 1: Highest labels Feb 22, 2022
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AzaharaC I did yarn tap --ts --timeout=9999 packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts and it failed with the logs pasted below.
Do you still have time to finish this or should I take it over? It's fine either way, just let me know. And sorry again for the slow reviews!

yarn run v1.18.0
$ /*******/cactus/node_modules/.bin/tap --ts --timeout=9999 packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2> Unable to find Jest's global expect.
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2> Please check you have added jest-extended correctly to your jest configuration.
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2> See https://github.com/jest-community/jest-extended#setup for help.
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1> [2022-02-22T00:17:16.132Z] INFO (plugin-ledger-connector-corda): Instantiating web services for @hyperledger/cactus-plugin-ledger-connector-corda...
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1> [2022-02-22T00:17:16.133Z] DEBUG (AuthorizationOptionsProvider): Created instance of AuthorizationOptionsProvider OK
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1> [2022-02-22T00:17:16.133Z] DEBUG (deploy-contract-jars-endpoint): Instantiated DeployContractJarsEndpoint OK
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1> [2022-02-22T00:17:16.133Z] INFO (plugin-ledger-connector-corda): Instantiated endpoints of @hyperledger/cactus-plugin-ledger-connector-corda
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1> [2022-02-22T00:17:16.133Z] INFO (plugin-ledger-connector-corda): Instantiating web services for @hyperledger/cactus-plugin-ledger-connector-corda...
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1> [2022-02-22T00:17:16.133Z] DEBUG (AuthorizationOptionsProvider): Created instance of AuthorizationOptionsProvider OK
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1> [2022-02-22T00:17:16.133Z] DEBUG (deploy-contract-jars-endpoint): Instantiated DeployContractJarsEndpoint OK
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1> [2022-02-22T00:17:16.133Z] INFO (plugin-ledger-connector-corda): Instantiated endpoints of @hyperledger/cactus-plugin-ledger-connector-corda
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2> Error: Servers#shutdown() Failed to shut down server Error [ERR_SERVER_NOT_RUNNING]: Server is not running.
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at new NodeError (node:internal/errors:371:5)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at Server.close (node:net:1613:12)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at Object.onceWrapper (node:events:513:28)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at Server.emit (node:events:394:28)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at Server.emit (node:domain:475:12)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at emitCloseNT (node:net:1666:8)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at processTicksAndRejections (node:internal/process/task_queues:82:21)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at /*******/cactus/packages/cactus-common/src/main/typescript/servers.ts:15:21
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at Server.close (node:net:1613:9)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at Object.onceWrapper (node:events:513:28)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at Server.emit (node:events:394:28)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at Server.emit (node:domain:475:12)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at emitCloseNT (node:net:1666:8)
packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 2>     at processTicksAndRejections (node:internal/process/task_queues:82:21)
 FAIL  packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts
 ✖ Error: connect ECONNREFUSED 127.0.0.1:12112

  test: packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts
  operator: error
  stack: |-
    Error: connect ECONNREFUSED 127.0.0.1:12112
        at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1146:16)

 FAIL  packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1 failed of 1 5m
 ✖ Error: connect ECONNREFUSED 127.0.0.1:12112


                         
  🌈 SUMMARY RESULTS 🌈  
                         

 FAIL  packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts 1 failed of 1 5m
 ✖ Error: connect ECONNREFUSED 127.0.0.1:12112

Suites:   1 failed, 1 of 1 completed
Asserts:  1 failed, of 1
Time:     5m

@petermetz
Copy link
Contributor

Closing this for now as part of the PR backlog tidying. We can re-open later as needed.

@petermetz petermetz closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Corda P1 Priority 1: Highest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(connector-corda): support corda 5 RC via TS/HTTP (no JVM)
2 participants