feat(cactus-api-client): common verifier-factory

[outSH]

• Adjust SocketIOApiClient and common Verifier behavior to previous one in cmd-socketio, fix related tests.
• Extract Verifier interfaces to common location to ensure interface compatibility between old and new verifier / verifier factory (both should implement same interface).
• Create new package cactus-verifier-client for common verifier related stuff, to prevent circular dependencies.
• Add verifier-factory to create verifiers by supplying it's ID only, based on initial configuration. Configuration is set in ctor, but can be read from a file as in cmd-socketio scenarious. VerifierFactory config should be compatible with existing ledgerPluginInfo.

Signed-off-by: Michal Bajer michal.bajer@fujitsu.com

[outSH]

@petermetz
As described in #1878, we need to include common "VerifierFactory" for release 1.0. I'm very sorry for such a short notice for feature like that, but it turned out to be needed just recently.

I'm still working on this task, but the core design proposal is complete, so please review in spare time and let me know what to clarify or improve :)

The interesting parts are:

• Implementation: packages/cactus-api-client/src/main/typescript/verifier-factory.ts
• Use sample: packages/cactus-test-api-client/src/test/typescript/integration/verifier-factory.test.ts

I will add more tests and do some more improvements tomorrow.

[outSH]

There's another branch where I've adjusted electricity-trade to use new verifier factory (sort of sanity test). It breaks dockerization though, so it's not included here (need a simpler way to use local cactus packages, without pushing them to npm first). To start the sample just follow the readme as usual, open another shell, cp config/* /etc/cactus/ and node ./dist/www.js to start BLP in this shell.

Branch - https://github.com/outSH/cactus/tree/electricity_trade_common_verifier

[outSH]

@izuru0 @takeutak Please review

[petermetz]

@petermetz Once again, this is not an interface for legacy-socketio (-socketio connectors), but in the end to all the connectors, including openapi ones. This is the verifier component documented in the whitepaper, but modified to support all connectors / validators.

@outSH OK, cool.

The following is a not a change request, just something to ponder: Making a package that is intended to re-export literally every connector package (of which the number is to grow infinitely by design) will have a bundle size trending to infinity as well. This is especially important for browser based applications where the end user experience depends heavily on bundle size.

[outSH]

Making a package that is intended to re-export literally every connector package (of which the number is to grow infinitely by design) will have a bundle size trending to infinity as well. This is especially important for browser based applications where the end user experience depends heavily on bundle size.

@petermetz Yes, that was my concern few messages above as well, but it's a requirement from one of the teams already using verifier interface. In the follow up PR I want to investigate possibility of importing apiclient modules dynamically, but this is not critical now when we only import 2 or 3 clients.

[izuru0]

LGTM

[petermetz]

Making a package that is intended to re-export literally every connector package (of which the number is to grow infinitely by design) will have a bundle size trending to infinity as well. This is especially important for browser based applications where the end user experience depends heavily on bundle size.

@petermetz Yes, that was my concern few messages above as well, but it's a requirement from one of the teams already using verifier interface. In the follow up PR I want to investigate possibility of importing apiclient modules dynamically, but this is not critical now when we only import 2 or 3 clients.

@outSH I guess in an ideal situation they would understand that using pre-1.0.0 software means that there will be breaking changes, but I know that's not how you roll over there so that's totally fair.

[petermetz]

@outSH LGTM, thank you for the updates and putting up with my nit-picking as usual!