fix(api-server): allow no authorization on socketio endpoints #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petermetz @izuru0 @takeutak Please review |
petermetz
requested changes
Mar 15, 2022
packages/cactus-cmd-api-server/src/main/typescript/api-server.ts
Outdated
Show resolved
Hide resolved
outSH
force-pushed
the
fix_no_auth_socketio
branch
from
65962fd to
9137bd8
Compare
outSH
force-pushed
the
fix_no_auth_socketio
branch
from
9137bd8 to
77c5452
Compare
petermetz
approved these changes
Mar 21, 2022
authorizeSocket middleware will be installed only if AuthorizationProtocol different than NONE was provided. Closes: hyperledger-cacti#1925 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
force-pushed
the
fix_no_auth_socketio
branch
from
77c5452 to
310ce6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authorizeSocket middleware will be installed only if AuthorizationProtocol different than NONE was provided.
Closes: #1925
Signed-off-by: Michal Bajer michal.bajer@fujitsu.com
Note
AuthorizerFactory.createMiddleware, but I didn't want to touch it without test coverage. I will probably introduce some tests with of socketio authorization as part of other PR, we can think about improvements then.