refactor(connector-go-ethereum-socketio): fix strict flag warnings #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
outSH
added a commit
to outSH/cactus
that referenced
this pull request
May 31, 2022
- Add functional test of all functions from go-ethereum-socketio validator. - Refactor go-ethereum validator to allow importing as a module, to simplify the functional test. - Fix sendRawTransaction to work with Verifier protocol. It couldn't be reached by any client library until now, so I consider this as "private" interface. - Add common web3 client object in openethereum test ledger helper class. - Add few new functions to ethereum test ledger helper class: newEthPersonalAccount, transferAssetFromCoinbase, deployContract. Depends on hyperledger-cacti#2051 Depends on hyperledger-cacti#2047 Closes: hyperledger-cacti#2052 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
jagpreetsinghsasan
approved these changes
Jun 1, 2022
outSH
force-pushed
the
go_eth_strict_flag_fix_new_pr
branch
from
eb31f12 to
87fef17
Compare
outSH
force-pushed
the
go_eth_strict_flag_fix_new_pr
branch
from
87fef17 to
490ebf9
Compare
petermetz
reviewed
Jul 13, 2022
...ctus-plugin-ledger-connector-go-ethereum-socketio/src/main/typescript/common/core/bin/www.ts
Show resolved
Hide resolved
petermetz
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
@outSH LGTM, please take a quick look at this comment I left here for future reference: https://github.com/hyperledger/cactus/pull/2051/files#r920445350
petermetz
force-pushed
the
go_eth_strict_flag_fix_new_pr
branch
from
490ebf9 to
8e2d8db
Compare
outSH
force-pushed
the
go_eth_strict_flag_fix_new_pr
branch
from
8e2d8db to
c25e70f
Compare
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag. Related issue: hyperledger-cacti#1671 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
force-pushed
the
go_eth_strict_flag_fix_new_pr
branch
from
c25e70f to
7e3ee0d
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Nov 21, 2022
- Add functional test of all functions from go-ethereum-socketio validator. - Refactor go-ethereum validator to allow importing as a module, to simplify the functional test. - Fix sendRawTransaction to work with Verifier protocol. It couldn't be reached by any client library until now, so I consider this as "private" interface. - Add common web3 client object in openethereum test ledger helper class. - Add few new functions to ethereum test ledger helper class: newEthPersonalAccount, transferAssetFromCoinbase, deployContract. Depends on hyperledger-cacti#2051 Depends on hyperledger-cacti#2047 Closes: hyperledger-cacti#2052 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Nov 22, 2022
- Add functional test of all functions from go-ethereum-socketio validator. - Refactor go-ethereum validator to allow importing as a module, to simplify the functional test. - Fix sendRawTransaction to work with Verifier protocol. It couldn't be reached by any client library until now, so I consider this as "private" interface. - Add common web3 client object in openethereum test ledger helper class. - Add few new functions to ethereum test ledger helper class: newEthPersonalAccount, transferAssetFromCoinbase, deployContract. Depends on hyperledger-cacti#2051 Depends on hyperledger-cacti#2047 Closes: hyperledger-cacti#2052 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Nov 22, 2022
- Add functional test of all functions from go-ethereum-socketio validator. - Refactor go-ethereum validator to allow importing as a module, to simplify the functional test. - Fix sendRawTransaction to work with Verifier protocol. It couldn't be reached by any client library until now, so I consider this as "private" interface. - Add common web3 client object in openethereum test ledger helper class. - Add few new functions to ethereum test ledger helper class: newEthPersonalAccount, transferAssetFromCoinbase, deployContract. Depends on hyperledger-cacti#2051 Depends on hyperledger-cacti#2047 Closes: hyperledger-cacti#2052 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
that referenced
this pull request
Nov 22, 2022
- Add functional test of all functions from go-ethereum-socketio validator. - Refactor go-ethereum validator to allow importing as a module, to simplify the functional test. - Fix sendRawTransaction to work with Verifier protocol. It couldn't be reached by any client library until now, so I consider this as "private" interface. - Add common web3 client object in openethereum test ledger helper class. - Add few new functions to ethereum test ledger helper class: newEthPersonalAccount, transferAssetFromCoinbase, deployContract. Depends on #2051 Depends on #2047 Closes: #2052 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.
Related issue: #1671
Signed-off-by: Michal Bajer michal.bajer@fujitsu.com