docs(examples): add workshop 2022-11-14 examples #2204

RafaelAPB · 2022-11-14T14:38:54Z

Simple examples using Cacti tailored for the workshop.

Thanks to @AndreAugusto11 and Monica Gomez monicasrgomez@gmail.com @msrgomez for the amazing work.

Works with version 1.0.0 of cactus-tooling.

Depends on #2213
Depends on #2223

examples/cactus-workshop-examples/src/main/typescript/hello-world.ts

yarn.lock

examples/cactus-workshop-examples/package.json

takeutak · 2022-11-21T23:47:00Z

@RafaelAPB Thanks for your contribution and hard work to develop a workshop example!
As Peter suggested, the directory name (cactus-workshop-example) should be changed to some identified name such as cactus-workshop-examples-2022-11-14 because there will be another workshop example in the future.

(@petermetz BTW, the prefix "cactus-" will be changed to cacti- in the future, is it right?)

RafaelAPB · 2022-11-22T12:56:01Z

@petermetz and @takeutak, the updates you recommended have been incorporated

petermetz

@RafaelAPB Both the description and the package name (and directory name) should be pinned to the actual workshop instance (2022-11-14) so that we can add more of these packages later

Please fix the above request from earlier and
Squash into a single commit
Update the tsconfig.json to match the conventions of the other packages if possible (if not possible for whatever reason, then let's discuss the details)
Mark the issue dependent with the correct syntax both in the PR description and the commit message.
Set the PR title to match the final remaining (one) commit's subject line.
Make sure that the commit subject line is also identifying the workshop instance.
Make sure that the README title is also identifying the workshop instance.

takeutak · 2022-11-23T00:40:35Z

@RafaelAPB

@petermetz and @takeutak, the updates you recommended have been incorporated

Thanks! It is no problem for me, but could you revise this pull-request according to Peter's request? After that I will approve it.

RafaelAPB · 2022-11-24T23:37:03Z

@

@RafaelAPB Both the description and the package name (and directory name) should be pinned to the actual workshop instance (2022-11-14) so that we can add more of these packages later

Please fix the above request from earlier and

Squash into a single commit

Update the tsconfig.json to match the conventions of the other packages if possible (if not possible for whatever reason, then let's discuss the details)

Mark the issue dependent with the correct syntax both in the PR description and the commit message.

Set the PR title to match the final remaining (one) commit's subject line.

Make sure that the commit subject line is also identifying the workshop instance.

Make sure that the README title is also identifying the workshop instance.

@petermetz updated. Not sure about the changes required for steps 3 and 4.

jagpreetsinghsasan

LGTM, its nice to have such simple examples as well, for getting started.

takeutak · 2022-11-30T06:05:20Z

LGTM, but this pull-request cannot be merged without resolving this change-request from Peter due to GitHub system.

@petermetz If you have some improvement comments, please feel free to share them.

petermetz

LGTM but will mark it with a change request so that we know that it has to be updated after v1.1.3 comes out (which is dropping soon)

github-actions · 2022-12-09T00:23:15Z

This PR/issue depends on:

~~fix(test-tooling): substrate test ledger fails if WS_PORT not specified #2213~~
~~chore(release): publish v1.1.3 #2223~~
By Dependent Issues (🤖). Happy coding!

petermetz

@RafaelAPB Please update to v1.1.3 and then if you run yarn it should disappear the unnecessary diff from the lock file.

petermetz

@RafaelAPB You don't appear to have ran yarn to make the lock file changes necessary.

RafaelAPB · 2023-01-18T09:57:28Z

@RafaelAPB You don't appear to have ran yarn to make the lock file changes necessary.

should be good to go now! Thanks for the patience

petermetz

@RafaelAPB No worries and thanks for the updates, LGTM.

@AndreAugusto11

Simple examples using Cacti tailored for the workshop 2022-11-14. Thanks to @AndreAugusto11 and Monica Gomez monicasrgomez@gmail.com @msrgomez for the amazing work. Works with version 1.0.0 of cactus-tooling. Depends on hyperledger-cacti#2213 Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt> Signed-off-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Co-Authored-By: Monica Gomez <monicasrgomez@gmail.com> Co-Authored-By: André Augusto <andre.augusto@tecnico.ulisboa.pt> Co-Authored-By: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt>

RafaelAPB requested review from petermetz, takeutak, izuru0, jagpreetsinghsasan and sandeepnRES as code owners November 14, 2022 14:38

RafaelAPB force-pushed the workshop-examples branch from 30b74ec to c224740 Compare November 14, 2022 14:39

github-advanced-security bot found potential problems Nov 14, 2022

View reviewed changes

RafaelAPB force-pushed the workshop-examples branch 3 times, most recently from c220118 to 3ba2ff4 Compare November 14, 2022 15:27

github-advanced-security bot found potential problems Nov 14, 2022

View reviewed changes

examples/cactus-workshop-examples/src/main/typescript/hello-world.ts Fixed Show fixed Hide fixed

petermetz requested changes Nov 15, 2022

View reviewed changes

RafaelAPB mentioned this pull request Nov 22, 2022

fix(test-tooling): substrate test ledger fails if WS_PORT not specified #2213

Closed

RafaelAPB force-pushed the workshop-examples branch 2 times, most recently from eb81c18 to ed013dd Compare November 22, 2022 12:55

RafaelAPB requested review from petermetz and removed request for sandeepnRES, jagpreetsinghsasan, takeutak, izuru0 and petermetz November 22, 2022 12:56

petermetz requested changes Nov 22, 2022

View reviewed changes

RafaelAPB force-pushed the workshop-examples branch 2 times, most recently from 664b20a to 05ebc2f Compare November 24, 2022 23:36

RafaelAPB changed the title ~~Workshop examples~~ feat(examples): add workshop 2022-11-14 examples Nov 24, 2022

RafaelAPB force-pushed the workshop-examples branch 2 times, most recently from 43ce2cd to bd6470c Compare November 29, 2022 18:47

petermetz force-pushed the workshop-examples branch from bd6470c to 2b44403 Compare November 29, 2022 19:06

RafaelAPB force-pushed the workshop-examples branch from 5db8f34 to 52af78a Compare November 29, 2022 19:16

jagpreetsinghsasan approved these changes Nov 30, 2022

View reviewed changes

takeutak approved these changes Nov 30, 2022

View reviewed changes

github-actions bot removed the dependent label Dec 1, 2022

petermetz mentioned this pull request Dec 2, 2022

chore(release): publish v1.1.3 #2223

Closed

github-actions bot added the dependent label Dec 2, 2022

petermetz requested changes Dec 2, 2022

View reviewed changes

github-actions bot removed the dependent label Dec 9, 2022

RafaelAPB requested review from petermetz and removed request for izuru0, sandeepnRES and VRamakrishna December 13, 2022 18:39

petermetz requested changes Dec 23, 2022

View reviewed changes

RafaelAPB force-pushed the workshop-examples branch from 52af78a to c8486d7 Compare December 29, 2022 14:56

RafaelAPB requested a review from petermetz December 29, 2022 14:56

petermetz requested changes Jan 17, 2023

View reviewed changes

RafaelAPB force-pushed the workshop-examples branch from c8486d7 to c48fe13 Compare January 18, 2023 09:56

RafaelAPB force-pushed the workshop-examples branch from c48fe13 to e2e65ac Compare January 18, 2023 09:58

RafaelAPB requested a review from petermetz January 18, 2023 13:52

petermetz approved these changes Jan 19, 2023

View reviewed changes

petermetz force-pushed the workshop-examples branch from e2e65ac to 41c0ac0 Compare January 27, 2023 10:24

petermetz merged commit b33ab1b into hyperledger-cacti:main Jan 27, 2023

RafaelAPB deleted the workshop-examples branch January 30, 2024 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(examples): add workshop 2022-11-14 examples #2204

docs(examples): add workshop 2022-11-14 examples #2204

RafaelAPB commented Nov 14, 2022 •

edited by petermetz

Loading

takeutak commented Nov 21, 2022 •

edited

Loading

RafaelAPB commented Nov 22, 2022

petermetz left a comment •

edited

Loading

takeutak commented Nov 23, 2022 •

edited

Loading

RafaelAPB commented Nov 24, 2022

jagpreetsinghsasan left a comment

takeutak commented Nov 30, 2022

petermetz left a comment

github-actions bot commented Dec 9, 2022

petermetz left a comment

petermetz left a comment

RafaelAPB commented Jan 18, 2023

petermetz left a comment

docs(examples): add workshop 2022-11-14 examples #2204

docs(examples): add workshop 2022-11-14 examples #2204

Conversation

RafaelAPB commented Nov 14, 2022 • edited by petermetz Loading

takeutak commented Nov 21, 2022 • edited Loading

RafaelAPB commented Nov 22, 2022

petermetz left a comment • edited Loading

Choose a reason for hiding this comment

takeutak commented Nov 23, 2022 • edited Loading

RafaelAPB commented Nov 24, 2022

jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

takeutak commented Nov 30, 2022

petermetz left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2022

petermetz left a comment

Choose a reason for hiding this comment

petermetz left a comment

Choose a reason for hiding this comment

RafaelAPB commented Jan 18, 2023

petermetz left a comment

Choose a reason for hiding this comment

RafaelAPB commented Nov 14, 2022 •

edited by petermetz

Loading

takeutak commented Nov 21, 2022 •

edited

Loading

petermetz left a comment •

edited

Loading

takeutak commented Nov 23, 2022 •

edited

Loading