Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade decode-uri-component to >= 0.2.2 #2296

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

charellesandig
Copy link
Contributor

@charellesandig charellesandig commented Feb 20, 2023

@charellesandig charellesandig marked this pull request as ready for review February 23, 2023 08:19
@jagpreetsinghsasan jagpreetsinghsasan changed the title chore(deps): upgrade decode-uri-component to > 0.2.2 #2243 chore(deps): upgrade decode-uri-component to > 0.2.2 Feb 23, 2023
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charellesandig Please upgrade all occurrences of the problematic version of the dependency not just one.

$ npm ls decode-uri-component
@hyperledger/cactus@ /home/peter/a/blockchain/cactus
├─┬ @hyperledger/cactus-cmd-socketio-server@1.1.3 -> ./packages/cactus-cmd-socketio-server
│ └─┬ web3@1.8.2
│   └─┬ web3-bzz@1.8.2
│     └─┬ swarm-js@0.1.40
│       └─┬ xhr-request@1.1.0
│         └─┬ query-string@5.1.1
│           └── decode-uri-component@0.2.2 deduped
├─┬ @hyperledger/cactus-example-supply-chain-frontend@1.1.3 -> ./examples/cactus-example-supply-chain-frontend
│ └─┬ @angular-devkit/build-angular@13.3.5
│   └─┬ stylus@0.56.0
│     └─┬ css@3.0.0
│       └─┬ source-map-resolve@0.6.0
│         └── decode-uri-component@0.2.2 deduped
└─┬ @hyperledger/cactus-test-tooling@1.1.3 -> ./packages/cactus-test-tooling
  └─┬ keycloak-admin@1.14.22
    └─┬ query-string@6.14.1
      └── decode-uri-component@0.2.2

@charellesandig
Copy link
Contributor Author

charellesandig commented Mar 8, 2023

Hi @petermetz , for these packages I upgraded the direct dependencies where decode-uri-component occurs.

cactus-cmd-socketio-server
cactus-example-carbon-accounting-frontend
cactus-test-tooling
cactus-verifier-client

For cactus-verifier-client when I upgraded from "jest-extended": "0.11.5" to "jest-extended": "3.0.1" the docode-uri-component is not present anymore.

@petermetz petermetz self-requested a review April 11, 2023 17:23
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charellesandig Please see https://github.com/hyperledger/cacti/pull/2296#discussion_r1163124456
Once the dependency has been resolved (e.g. that other issue fixed) then please do the webpack build test again to see if it passes or not. If it does, then just re-request my review and we'll be good to go)

@charellesandig
Copy link
Contributor Author

Depends on: #2357

@gitguardian
Copy link

gitguardian bot commented Jul 12, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@adrianbatuto adrianbatuto force-pushed the issue2243 branch 2 times, most recently from 22d9ec6 to 93e46f7 Compare July 13, 2023 05:59
@petermetz petermetz changed the title chore(deps): upgrade decode-uri-component to > 0.2.2 chore(deps): upgrade decode-uri-component to >= 0.2.2 Jul 24, 2023
@petermetz petermetz self-requested a review July 24, 2023 21:34
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't merge until maintainer consensus has been achieved.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased onto upstream/main, fixed the merge conflicts and in the meantime Izuru reviewed it too, so we are good to go.

Fixes https://github.com/hyperledger/cacti/issues/2243

Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: charelle.sandig <charelle.wrk@gmail.com>
@petermetz petermetz merged commit 38f1f75 into hyperledger-cacti:main Aug 17, 2023
107 of 117 checks passed
@petermetz petermetz deleted the issue2243 branch September 15, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(deps): upgrade decode-uri-component to >= 0.2.2
4 participants